Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

😈 [Improvement Proposal] - Extend initialize function to include feature flags for alpha / breaking changes #859

Closed
HarshRajat opened this issue Nov 20, 2023 · 1 comment · Fixed by #888
Assignees
Labels
enhancement New feature or request priority-2 Major priority

Comments

@HarshRajat
Copy link
Contributor

Proposal name

Create a way by which alpha can be integrated into stable version without breaking compatibility

Describe the Proposal

Create a way by which alpha can be integrated into Stable version without breaking compatibility via the use of feature flags.

Flow:

  • Initialize user will have options.alpha.feature which will be an array of string constants (CONSTANTS.ALPHA.FEATURE.{feature_name}.
  • This will enable us to merge alpha versions to stable without breaking compatibility as any alpha logic that breaks functionality is turned off but any read functionality is already live as soon as the feature is done.

Referring to this API: https://push.org/docs/chat/build/initialize-user/

Use Case

  • Enables new features to be merged in stable as soon as they are done and elongates backward compatibility in most cases.

Current Limitations

  • No solution exist to get current implementations of Push SDK to start supporting any breaking changes without breaking the version.
@HarshRajat HarshRajat added this to the Push for ETHIndia 2023 milestone Nov 20, 2023
@HarshRajat HarshRajat added enhancement New feature or request priority-2 Major priority labels Nov 21, 2023
@Aman035 Aman035 linked a pull request Nov 27, 2023 that will close this issue
@Aman035
Copy link
Member

Aman035 commented Dec 1, 2023

Done by #888

@Aman035 Aman035 closed this as completed Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority-2 Major priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants