Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [BUG] - Fix the ui representation of domain resolution process #1327

Closed
mishramonalisha76 opened this issue May 29, 2024 · 2 comments · Fixed by #1336
Closed

🐛 [BUG] - Fix the ui representation of domain resolution process #1327

mishramonalisha76 opened this issue May 29, 2024 · 2 comments · Fixed by #1336
Assignees
@mishramonalisha76
Labels
bug Something isn't working

Comments

@mishramonalisha76
Copy link
Contributor

Expected Behaviour

When a domain is passed as chatID , it should show the domain only.

Current Behaviour

It resolves to address and then back to domain

Reproduction steps

1. Go to ChatPreviewSearchList Component test file
2. Add a domain name 
3. Run the sdk sandbox and open the ChatPreviewSearchList

Screenshots

![DESCRIPTION](LINK.png)

Relevant Logs

No response

Dapp Env

Prod (app.push.org), Staging (staging.push.org), Dev (dev.push.org)

Browsers

No response
@mishramonalisha76 mishramonalisha76 added the bug Something isn't working label May 29, 2024
@mishramonalisha76 mishramonalisha76 self-assigned this May 29, 2024
This was referenced May 29, 2024
Merged
Merged
@mishramonalisha76 mishramonalisha76 linked a pull request Jun 5, 2024 that will close this issue
fixes ui representation for domain resolution #1336
Merged
5 tasks
@rohitmalhotra1420
Copy link
Collaborator

This will be going live with the changes of : #1338

@rohitmalhotra1420
Copy link
Collaborator

Got released in uiweb - 1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mishramonalisha76 mishramonalisha76

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes ui representation for domain resolution push-protocol/push-sdk
2 participants
@rohitmalhotra1420 @mishramonalisha76