Skip to content

Commit 915d1ea

Browse files
Enable more node tests to run on run-acceptance-tests (#3931)
These tests were not running on pull requests because `run-acceptance-tests` runs all tests in short mode by default. The assertion that these tests provision node balancers and thus need more than a KinD cluster seem incorrect at first glance; we should be able to run them on a KinD cluster. This pull request removes the `tests.SkipIfShort` condition on these tests. Tests now enabled are: - TestAccGuestbook - TestAccHelm - TestAccHelmLocal - TestAccPrometheusOperator - TestHelmRelease - TestHelmReleaseNamespace
1 parent d439b20 commit 915d1ea

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

tests/sdk/nodejs/examples/examples_test.go

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ func TestAccMinimal(t *testing.T) {
4343
}
4444

4545
func TestAccGuestbook(t *testing.T) {
46-
tests.SkipIfShort(t, "test provisions a load balancer and requires a cloud provider cluster to run")
4746
test := getBaseOptions(t).
4847
With(integration.ProgramTestOptions{
4948
Dir: filepath.Join(getCwd(t), "guestbook"),
@@ -164,7 +163,6 @@ func TestAccIngress(t *testing.T) {
164163
}
165164

166165
func TestAccHelm(t *testing.T) {
167-
tests.SkipIfShort(t, "test provisions a load balancer and requires a cloud provider cluster to run")
168166
test := getBaseOptions(t).
169167
With(integration.ProgramTestOptions{
170168
Dir: filepath.Join(getCwd(t), "helm", "step1"),
@@ -260,7 +258,6 @@ func TestAccHelmAllowCRDRendering(t *testing.T) {
260258
}
261259

262260
func TestAccHelmLocal(t *testing.T) {
263-
tests.SkipIfShort(t, "test provisions a load balancer and requires a cloud provider cluster to run")
264261
test := getBaseOptions(t).
265262
With(integration.ProgramTestOptions{
266263
Dir: filepath.Join(getCwd(t), "helm-local", "step1"),
@@ -304,7 +301,6 @@ func TestAccHelmLocal(t *testing.T) {
304301
}
305302

306303
func TestAccPrometheusOperator(t *testing.T) {
307-
tests.SkipIfShort(t, "test provisions a load balancer and requires a cloud provider cluster to run")
308304
test := getBaseOptions(t).
309305
With(integration.ProgramTestOptions{
310306
Dir: filepath.Join(getCwd(t), "prometheus-operator"),
@@ -360,7 +356,6 @@ func TestAccProvider(t *testing.T) {
360356
}
361357

362358
func TestHelmRelease(t *testing.T) {
363-
tests.SkipIfShort(t, "test provisions a load balancer and requires a cloud provider cluster to run")
364359
validationFunc := func(t *testing.T, stackInfo integration.RuntimeValidationStackInfo) {
365360
assert.NotEmpty(t, stackInfo.Outputs["redisMasterClusterIP"].(string))
366361
assert.Equal(t, stackInfo.Outputs["status"], "deployed")
@@ -446,7 +441,6 @@ func TestHelmReleaseCRD(t *testing.T) {
446441

447442
func TestHelmReleaseNamespace(t *testing.T) {
448443
// Validate fix for https://github.com/pulumi/pulumi-kubernetes/issues/1710
449-
tests.SkipIfShort(t, "test provisions a load balancer and requires a cloud provider cluster to run")
450444
test := getBaseOptions(t).
451445
With(integration.ProgramTestOptions{
452446
Dir: filepath.Join(getCwd(t), "helm-release-namespace", "step1"),
@@ -516,7 +510,6 @@ func TestHelmReleaseRedis(t *testing.T) {
516510
}
517511

518512
// Validate fix for https://github.com/pulumi/pulumi-kubernetes/issues/1933
519-
tests.SkipIfShort(t, "test provisions a load balancer and requires a cloud provider cluster to run")
520513
test := getBaseOptions(t).
521514
With(integration.ProgramTestOptions{
522515
Dir: filepath.Join(getCwd(t), "helm-release-redis", "step1"),

0 commit comments

Comments
 (0)