Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update environment returns the revision that was just created #15

Open
liamawhite opened this issue Jun 6, 2024 · 2 comments
Open

Update environment returns the revision that was just created #15

liamawhite opened this issue Jun 6, 2024 · 2 comments
Assignees
Labels
kind/enhancement Improvements or new features

Comments

@liamawhite
Copy link

liamawhite commented Jun 6, 2024

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

  1. Revision number is at 10
  2. UpdateEnvironment is called, returns revision 11 as part of the sdk API

This way it avoids the edge case where something (or someone) else updates the environment before your are able to list the revisions i.e. it makes it somewhat atomic.

Our use case here is we update the environment and then use that revision to pass through a pipeline tagging as dev, staging, prod, running pulumi up at each step.

Affected area/feature

Esc SDK

@liamawhite liamawhite added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Jun 6, 2024
@cleverguy25
Copy link
Contributor

This makes sense, I will work on an update here.

@cleverguy25 cleverguy25 removed the needs-triage Needs attention from the triage team label Jun 6, 2024
@cleverguy25 cleverguy25 self-assigned this Jun 6, 2024
@komalali
Copy link
Member

komalali commented Jun 6, 2024

This is also what PSP does, so makes sense to be consistent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

3 participants