From 32021bc17ecec8fd18329204068c1f6abb8e4f3a Mon Sep 17 00:00:00 2001 From: Jannis R Date: Fri, 10 Feb 2023 11:40:11 +0100 Subject: [PATCH] =?UTF-8?q?SNCB/NMBS:=20document=20profile=20as=20broken?= =?UTF-8?q?=20=F0=9F=93=9D,=20skip=20E2E/integration=20tests=20=E2=9C=85?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit back-port of 2639448 to 5.x related: https://github.com/public-transport/hafas-client/issues/284 --- p/readme.md | 2 +- p/sncb/readme.md | 2 ++ test/e2e/sncb.js | 8 ++++---- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/p/readme.md b/p/readme.md index f5145257e..fbd1f3491 100644 --- a/p/readme.md +++ b/p/readme.md @@ -11,7 +11,7 @@ HAFAS endpoint | wrapper library | docs | example code | profile name [Deutsche Bahn (DB)](https://en.wikipedia.org/wiki/Deutsche_Bahn) | [`db-hafas`](https://github.com/public-transport/db-hafas) | [docs](db/readme.md) | [example](db/example.js) | [`db`](db) [Swiss Railways (SBB)](https://en.wikipedia.org/wiki/Swiss_Federal_Railways) | - | [docs](sbb/readme.md) | [example](sbb/example.js) | [`sbb`](sbb) [Polskie Koleje Państwowe (PKP)](https://en.wikipedia.org/wiki/Polish_State_Railways) | [`pkp-hafas`](https://github.com/juliuste/pkp-hafas) | [docs](pkp/readme.md) | [example](pkp/example.js) | [`pkp`](pkp) -[Belgian National Railways (SNCB/NMBS)](https://en.wikipedia.org/wiki/National_Railway_Company_of_Belgium) | - | [docs](sncb/readme.md) | [example](sncb/example.js) | [`sncb`](sncb) +[Belgian National Railways (SNCB/NMBS)](https://en.wikipedia.org/wiki/National_Railway_Company_of_Belgium) | - | [docs](sncb/readme.md) | [example](sncb/example.js) | [`sncb`](sncb) (currently broken) [*Iarnród Éireann* (Irish Rail)](https://en.wikipedia.org/wiki/Iarnród_Éireann) | - | [docs](irish-rail/readme.md) | [example](irish-rail/example.js) | [`irish-rail`](irish-rail) [Berlin & Brandenburg public transport (VBB)](https://en.wikipedia.org/wiki/Verkehrsverbund_Berlin-Brandenburg) | [`vbb-hafas`](https://github.com/public-transport/vbb-hafas) | [docs](vbb/readme.md) | [example](vbb/example.js) | [`vbb`](vbb) [Berlin public transport (BVG)](https://en.wikipedia.org/wiki/Berliner_Verkehrsbetriebe) | [`bvg-hafas`](https://github.com/public-transport/bvg-hafas) | [docs](bvg/readme.md) | [example](bvg/example.js) | [`bvg`](bvg) diff --git a/p/sncb/readme.md b/p/sncb/readme.md index c961d4d63..1074d42dd 100644 --- a/p/sncb/readme.md +++ b/p/sncb/readme.md @@ -1,5 +1,7 @@ # SNCB profile for `hafas-client` +*Note:* **This profile is currently broken** because [SNCB has switched the HAFAS API style](https://github.com/public-transport/hafas-client/issues/284) and we haven't migrated to the new API. + [*Société nationale des chemins de fer belges (SNCB)*/*Nationale Maatschappij der Belgische Spoorwegen (NMBS)*](https://en.wikipedia.org/wiki/National_Railway_Company_of_Belgium) is the major public transport provider of [Belgium](https://en.wikipedia.org/wiki/Belgium). This profile adds *SNCB*-specific customizations to `hafas-client`. ## Usage diff --git a/test/e2e/sncb.js b/test/e2e/sncb.js index ed2d5da2c..fcb1ae7b6 100644 --- a/test/e2e/sncb.js +++ b/test/e2e/sncb.js @@ -36,7 +36,7 @@ const gentPaddenhoek = { latitude: 51.051691, longitude: 3.724914, } -tap.test('journeys – Gent Sant Pieters to Bruxelles Midi', async (t) => { +tap.skip('journeys – Gent Sant Pieters to Bruxelles Midi', async (t) => { const res = await client.journeys(gentStPieters, bruxellesMidi, { results: 4, departure: when, @@ -56,7 +56,7 @@ tap.test('journeys – Gent Sant Pieters to Bruxelles Midi', async (t) => { // todo: via works – with detour // todo: without detour -tap.test('trip details', async (t) => { +tap.skip('trip details', async (t) => { const res = await client.journeys(gentStPieters, bruxellesMidi, { results: 1, departure: when }) @@ -70,7 +70,7 @@ tap.test('trip details', async (t) => { t.end() }) -tap.test('arrivals at Bruxelles Midi', async (t) => { +tap.skip('arrivals at Bruxelles Midi', async (t) => { const arrivals = await client.arrivals(bruxellesMidi, { duration: 10, when }) @@ -86,7 +86,7 @@ tap.test('arrivals at Bruxelles Midi', async (t) => { // todo: nearby -tap.test('radar', async (t) => { +tap.skip('radar', async (t) => { const vehicles = await client.radar({ north: 51.065, west: 3.688,