Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upstream SDL2 #21

Closed
12 tasks done
sharkwouter opened this issue Dec 15, 2021 · 4 comments
Closed
12 tasks done

Use upstream SDL2 #21

sharkwouter opened this issue Dec 15, 2021 · 4 comments

Comments

@sharkwouter
Copy link
Member

sharkwouter commented Dec 15, 2021

Upstream SDL2 is currently in a mostly usable state for the PSP, even if it's not quite on par with our fork yet. We should make PRs to upstream to get it to the point where it's at least as good and ship it instead of our fork. This will reduce work for us and make sure SDL2 for PSP stays in a good spot.

Before we do this, here is a list of changes needed in upstream SDL:

@sharkwouter
Copy link
Member Author

sharkwouter commented Dec 15, 2021

Here we need to make sure the quality of the commits is good, changes are as small as needed and PRs are specific to one issue/improvement. We want the end result to be maintainable and we want upstream to be able to accept our changes.

We also don't want to repeat loading a small amount of textures causing out of memory errors because the vram is full.

@sharkwouter
Copy link
Member Author

I tested the old commit for rendering to texture and it's not really a good implementation. It works if there is only 1 texture being rendered to. If there are more layers, it doesn't work anymore.

@sharkwouter
Copy link
Member Author

Most of the rendering issues we face have been at least partially fixed in this PR to one of the SDL2 forks for PSP: joel16/SDL2#5

@sharkwouter
Copy link
Member Author

Upstream SDL is now used in the toolchain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant