diff --git a/src/requests/cookies.py b/src/requests/cookies.py index f69d0cda9e..fc1fec6bf5 100644 --- a/src/requests/cookies.py +++ b/src/requests/cookies.py @@ -408,7 +408,7 @@ def _find_no_duplicates(self, name, domain=None, path=None): # we will eventually return this as long as no cookie conflict toReturn = cookie.value - if toReturn: + if toReturn is not None: return toReturn raise KeyError(f"name={name!r}, domain={domain!r}, path={path!r}") diff --git a/tests/test_requests.py b/tests/test_requests.py index 75d2deff2e..e0100b5401 100644 --- a/tests/test_requests.py +++ b/tests/test_requests.py @@ -1299,6 +1299,14 @@ def test_cookie_as_dict_keeps_len(self): assert len(d2) == 2 assert len(d3) == 2 + def test_cookie_empty_value(self): + """Empty string cookie values should be retrievable.""" + jar = requests.cookies.RequestsCookieJar() + jar.set("empty", "") + + assert jar["empty"] == "" + assert jar.get("empty") == "" + def test_cookie_as_dict_keeps_items(self): key = "some_cookie" value = "some_value"