[console] fix false positive - console argument value when using ternary (#267)

Author: seferov

src/Handler/ConsoleHandler.php

@@ -278,7 +278,7 @@ private static function normalizeParams(array $params, array $args): array
     /**
      * @param mixed $mode
      */
-    private static function getModeValue($mode): int
+    private static function getModeValue($mode): ?int
     {
         if ($mode instanceof Expr\BinaryOp\BitwiseOr) {
             return self::getModeValue($mode->left) | self::getModeValue($mode->right);
@@ -298,6 +298,10 @@ private static function getModeValue($mode): int
             return $value;
         }
 
+        if ($mode instanceof Expr\Ternary) {
+            return null;
+        }
+
         throw new InvalidConsoleModeException();
     }
 

tests/acceptance/acceptance/console/ConsoleArgument.feature

@@ -241,3 +241,35 @@ Feature: ConsoleArgument
       | ->addArgument('arg1', InputArgument::IS_ARRAY)                            |
       | ->addArgument('arg1', InputArgument::IS_ARRAY \| InputArgument::REQUIRED) |
       | ->addArgument('arg1', InputArgument::IS_ARRAY \| InputArgument::OPTIONAL) |
+
+  Scenario: Assert using ternary operator as argument mode does not raise false positive
+    Given I have the following code
+      """
+      class MyCommand extends Command
+      {
+        private bool $foo;
+
+        public function __construct(bool $foo)
+        {
+          $this->foo = $foo;
+        }
+
+        public function configure(): void
+        {
+          $this->addArgument('arg', $this->foo ? InputArgument::REQUIRED : InputArgument::OPTIONAL);
+        }
+
+        public function execute(InputInterface $input, OutputInterface $output): int
+        {
+          /** @psalm-trace $arg */
+          $arg = $input->getArgument('arg');
+
+          return 0;
+        }
+      }
+      """
+    When I run Psalm
+    Then I see these errors
+      | Type  | Message            |
+      | Trace | $arg: null\|string |
+    And I see no other errors