Skip to content

Commit 7c3cda4

Browse files
committed
Code review
1 parent d61f771 commit 7c3cda4

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/InAppBrowser.ios.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,15 +186,17 @@ const InAppBrowser = (<any>NSObject).extend({
186186
}
187187
},
188188
dismissWithoutAnimation(controller: SFSafariViewController): void {
189-
const animationKey = 'dismissInAppBrowser';
190-
const ctrl = UIApplication.sharedApplication.keyWindow.rootViewController;
191189
const transition = CATransition.animation();
192190
transition.duration = 0.0;
193191
transition.timingFunction = CAMediaTimingFunction.functionWithName(kCAMediaTimingFunctionEaseInEaseOut);
194192
transition.type = kCATransitionFade;
195193
transition.subtype = kCATransitionFromBottom;
194+
196195
controller.view.alpha = 0.05;
197196
controller.view.frame = CGRectMake(0.0, 0.0, 0.5, 0.5);
197+
198+
const ctrl = UIApplication.sharedApplication.keyWindow.rootViewController;
199+
const animationKey = 'dismissInAppBrowser';
198200
ctrl.view.layer.addAnimationForKey(transition, animationKey);
199201
ctrl.dismissViewControllerAnimatedCompletion(false, () => {
200202
ctrl.view.layer.removeAnimationForKey(animationKey);

0 commit comments

Comments
 (0)