Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report output compatibility with DefectDojo #2076

Closed
security101 opened this issue Mar 12, 2023 · 4 comments
Closed

Report output compatibility with DefectDojo #2076

security101 opened this issue Mar 12, 2023 · 4 comments
Assignees
Labels
severity/informational Cosmetic or nice-to-have.

Comments

@security101
Copy link

New feature motivation

DefectDojo supported prowler v2.x csv and json output as import format. I looks like Prowler v3.y introduced a breaking change (see #1230) means report output (-M csv json) in not compatible anymore. An issue has been created for the DefectDojo project (see DefectDojo/django-DefectDojo#7348)

Solution Proposed

Preserving the prowler output format in the future would easy integration and usage without additional changes. May thank's in advance!

Describe alternatives you've considered

Announcing breaking changes upfront and provide details / the specification to ensure it can be considered by other development / maintenance team for their applications, e.g. DefectDojo, to ensure support and smooth upgrade experiences.

Additional context

No response

@security101 security101 added feature-request New feature request for Prowler. status/needs-triage Issue pending triage labels Mar 12, 2023
@jfagoagas
Copy link
Member

Hi @security101, I agree with you that preserving the output format is great to maintain compatibility with other integrations but Prowler v3 was a complete refactor of the existing v2 and we warn all the users about the breaking changes of the new version here https://github.com/prowler-cloud/prowler/releases/tag/3.0.0.

Is there anything we could do to help you to adapt it to the new V3 output format?

The new format specification is detailed here:

@jfagoagas jfagoagas added severity/informational Cosmetic or nice-to-have. and removed feature-request New feature request for Prowler. status/needs-triage Issue pending triage labels Mar 13, 2023
@jfagoagas jfagoagas self-assigned this Mar 13, 2023
@security101
Copy link
Author

Dear @jfagoagas,

thank you for looking into it.

The intention of my feature request is raising common awareness for future prowler changes. The issue has been taised to the defectdojo team (see DefectDojo/django-DefectDojo#7348 ) and they started to look into it. I am very confident that the DefectDojo import job will be updated resolving the issue.

I will post updates to this ticket if his if fine for you.

@jfagoagas
Copy link
Member

jfagoagas commented Mar 15, 2023

Sure! Thank you for raising this.

Keep us posted and if we could do something to help you to adapt DefectDojo to the latest Prowler version, please let us know.

Thanks again!

@toniblyx
Copy link
Member

I'm going to close this issue since no more to do in our side. Please @security101 let us know if we can help here in the future. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/informational Cosmetic or nice-to-have.
Projects
None yet
Development

No branches or pull requests

3 participants