Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's have a chat between different forks? :) #7

Open
rusefillc opened this issue Jan 14, 2022 · 14 comments
Open

Let's have a chat between different forks? :) #7

rusefillc opened this issue Jan 14, 2022 · 14 comments

Comments

@rusefillc
Copy link

rusefillc commented Jan 14, 2022

https://github.com/rusefi/gerbmerge has a dozen fixes related to KiCAD 6, 'rotate' fixes and at least one new feature 'flip' all done by @andreika-git

https://github.com/frank-f/gerbmerge is the one with most latest change @frank-f please comment on this ticket if you notice this ticket

https://github.com/ckemere/gerbmerge/ last commit Mar 7, 2021 @ckemere please comment on this ticket if you notice this ticket

https://github.com/jnicolson/gerbmerge/ last commit 2019 @jnicolson please comment on this ticket if you notice this ticket

@ckemere
Copy link

ckemere commented Jan 14, 2022

I'd love to know what the latest and greatest repo was! In particular, Python 3 would be awesome...

@jnicolson
Copy link

Hi - my fork should work on Python 3 (@ckemere), this was the main reason i worked on it. It was a while ago but it looks like i also refactored some things (split gerber and excellon parsing into different files for example)

@frank-f
Copy link

frank-f commented Jan 14, 2022

Well, hi 😄
My fork contains a few changes and fixes I made by myself, but also a few that I found while looking through other forks. It'd be nice to see those integrated into a collaboration.

I'd love to know what the latest and greatest repo was! In particular, Python 3 would be awesome...

I had a similar idea and took a short look at that, but that'll be a much larger undertaking. I haven't used too many features of gerbmerge myself yet, but a Python 3 migration would require exhaustive testing. So I put that idea aside for now.

@rusefillc
Copy link
Author

rusefillc commented Jan 14, 2022

@frank-f do you want to enable "issues" on your fork by the way? Same question for @jnicolson and @ckemere :)

Python 3 #8

Let's invite @sakoPO @eyal0 @GIPdA @bobc @provideyourown @olegart into this party

Question: shall we attempt anything as a group of people interested in gerbmerge? What can we attempt?

Shall we attempt a round of upstream PRs? Shall we go ask around asking to remove some of the abandoned forks? Is there nothing to do here really?

@frank-f
Copy link

frank-f commented Jan 14, 2022

Hi - my fork should work on Python 3 (@ckemere), this was the main reason i worked on it. It was a while ago but it looks like i also refactored some things (split gerber and excellon parsing into different files for example)

Nice work on the Python 3 support. I looked through your repo briefly and I think you have put the most work into your fork. If we're not finding some upstream to combine all our commits, I vote we continue based on your fork.

@rusefillc
Copy link
Author

@frank-f I am really glad that you are proposing https://github.com/jnicolson/gerbmerge as the new 'primary' fork!!! I've already created a couple of tickets there :)

@eyal0
Copy link

eyal0 commented Jan 15, 2022

My changes were minor, fixing bugs and adding support for G85. I reviewed my additions just now and I think that they were done well. If you like, please merge eyal0/master branch into whatever branch you like.

If you have questions, let me know.

@jnicolson
Copy link

@frank-f I am really glad that you are proposing https://github.com/jnicolson/gerbmerge as the new 'primary' fork!!! I've already created a couple of tickets there :)

I'm happy to help where i can - i'm not actively using gerbmerge any more (Even after the changes i made there was still too much i wanted to do) but i'm happy to do bits and pieces if it helps others - i'll probably just need others to test them.

@frank-f
Copy link

frank-f commented Jan 22, 2022

Did one of you manage to merge KiCad 6 gerbers yet? I'm getting lots of strange errors with Aperture Macros. Looking at older projects, it doesn't seem KiCad produced these before at all, so I don't even know what the script could expect as valid data.

@rusefillc
Copy link
Author

yes https://github.com/rusefi/gerbmerge/tree/rusefi-tests branch contains https://github.com/rusefi/gerbmerge/tree/rusefi-tests/examples/hellen121vag-c which are pretty recent KiCAD 5.99 gerbers - both inputs and merged outputs

@frank-f
Copy link

frank-f commented Jan 23, 2022

Turns out, KiCad has an option to disable the use of aperture macros. It says "not recommended", but adding support for it to gerbmerge seems to be a larger task since they're very versatile.

@rusefillc
Copy link
Author

FYI @andreika-git has ported https://github.com/rusefi/gerbmerge to python 3

see rusefi@f78db83

@kemerelab
Copy link

I just posted an issue - setup.py is still Python 2.0 unless I missed something?

@andreika-git
Copy link

andreika-git commented Mar 30, 2022

I just posted an issue - setup.py is still Python 2.0 unless I missed something?

Thanks for the report! Done:

rusefi@43eb624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants