Skip to content

Commit 111e5d8

Browse files
mhansencopybara-github
authored andcommitted
Make GeneratedMessageLite.mergeVarintField final
This improves opportunities for devirtualization and inlining. PiperOrigin-RevId: 875410937
1 parent 3c6858c commit 111e5d8

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

java/core/src/main/java/com/google/protobuf/GeneratedMessageLite.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -74,19 +74,19 @@ final void markImmutable() {
7474
memoizedSerializedSize &= ~MUTABLE_FLAG_MASK;
7575
}
7676

77-
int getMemoizedHashCode() {
77+
final int getMemoizedHashCode() {
7878
return memoizedHashCode;
7979
}
8080

81-
void setMemoizedHashCode(int value) {
81+
final void setMemoizedHashCode(int value) {
8282
memoizedHashCode = value;
8383
}
8484

85-
void clearMemoizedHashCode() {
85+
final void clearMemoizedHashCode() {
8686
memoizedHashCode = UNINITIALIZED_HASH_CODE;
8787
}
8888

89-
boolean hashCodeIsNotMemoized() {
89+
final boolean hashCodeIsNotMemoized() {
9090
return UNINITIALIZED_HASH_CODE == getMemoizedHashCode();
9191
}
9292

@@ -109,7 +109,7 @@ public final BuilderType newBuilderForType() {
109109
}
110110

111111
@SuppressWarnings("unchecked") // Guaranteed by runtime.
112-
MessageType newMutableInstance() {
112+
final MessageType newMutableInstance() {
113113
return (MessageType) dynamicMethod(MethodToInvoke.NEW_MUTABLE_INSTANCE, null, null);
114114
}
115115

@@ -143,7 +143,7 @@ public int hashCode() {
143143
return getMemoizedHashCode();
144144
}
145145

146-
int computeHashCode() {
146+
final int computeHashCode() {
147147
return Protobuf.getInstance().schemaFor(this).hashCode(this);
148148
}
149149

@@ -182,7 +182,7 @@ private void ensureUnknownFieldsInitialized() {
182182
*
183183
* @return {@code true} unless the tag is an end-group tag.
184184
*/
185-
protected boolean parseUnknownField(int tag, CodedInputStream input) throws IOException {
185+
protected final boolean parseUnknownField(int tag, CodedInputStream input) throws IOException {
186186
// This will avoid the allocation of unknown fields when a group tag is encountered.
187187
if (WireFormat.getTagWireType(tag) == WireFormat.WIRETYPE_END_GROUP) {
188188
return false;
@@ -193,7 +193,7 @@ protected boolean parseUnknownField(int tag, CodedInputStream input) throws IOEx
193193
}
194194

195195
/** Called by subclasses to parse an unknown field. For use by generated code only. */
196-
protected void mergeVarintField(int tag, int value) {
196+
protected final void mergeVarintField(int tag, int value) {
197197
ensureUnknownFieldsInitialized();
198198
unknownFields.mergeVarintField(tag, value);
199199
}

0 commit comments

Comments
 (0)