From b90e6940822d0f2c44c7ec0b264e00eaf83e9e53 Mon Sep 17 00:00:00 2001 From: Bartlomiej Plotka Date: Fri, 20 Dec 2024 09:37:22 +0100 Subject: [PATCH] Small fix to prombench Makefile to adjust for alpine docker image. (#813) No openssh installed, and fingerprint ask, so switching to HTTPs for git. alpine mktemp does not have -t apparently too. Signed-off-by: bwplotka --- prombench/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/prombench/Makefile b/prombench/Makefile index 4f570dea2..dae3c2532 100644 --- a/prombench/Makefile +++ b/prombench/Makefile @@ -34,7 +34,7 @@ cluster_delete: BENCHMARK_DIRECTORY := $(if $(BENCHMARK_DIRECTORY),$(BENCHMARK_DIRECTORY),manifests/prombench) # /prombench <...> --bench.version BENCHMARK_VERSION := $(if $(BENCHMARK_VERSION),$(BENCHMARK_VERSION),master) -PROMBENCH_GIT_REPOSITORY ?= git@github.com:prometheus/test-infra.git +PROMBENCH_GIT_REPOSITORY ?= https://github.com/prometheus/test-infra.git PROMBENCH_DIR ?= . # maybe_pull_custom_version allows custom benchmarking as designed in @@ -50,7 +50,7 @@ ifeq (${BENCHMARK_VERSION},master) @echo ">> Using standard benchmark configuration, from the docker image" else @echo ">> Git pulling custom benchmark configuration from the ${BENCHMARK_VERSION}" - @$(eval $@_TMP_DIR=$(shell mktemp -d -t "prombench")) + @$(eval $@_TMP_DIR=$(shell mktemp -d)) cd ${$@_TMP_DIR} && git clone ${PROMBENCH_GIT_REPOSITORY} ifeq ($(subst @,,${BENCHMARK_VERSION}),${BENCHMARK_VERSION}) @echo ">> --bench.version is a branch, reseting to origin/${BENCHMARK_VERSION}"