Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading long lines from TCP closes the connection #109

Closed
matthiasr opened this issue Nov 15, 2017 · 5 comments
Closed

Reading long lines from TCP closes the connection #109

matthiasr opened this issue Nov 15, 2017 · 5 comments

Comments

@matthiasr
Copy link
Contributor

When reading from TCP, we abort and close the connection if any line does not fit into the bufio.Reader buffer. This is really not necessary, and the standard library has higher-level methods to reliably read lines from a stream.

Any solution should make sure to process the last line in the stream, even if it does not end in a newline.

@matthiasr
Copy link
Contributor Author

I'm going to close this because apparently nobody is bothered by this. If you are, please comment here and open a PR!

@imriz
Copy link

imriz commented Apr 19, 2020

@matthiasr I just encountered this I think :)
Sending from Logstash's statsd output plugin.
BTW, I get the long line no matter how high I set statsd.read-buffer

@imriz
Copy link

imriz commented Apr 19, 2020

My root problem is probably due to reinh/statsd#76

@matthiasr
Copy link
Contributor Author

Oh interesting … but a different issue then. I'll make one

@matthiasr
Copy link
Contributor Author

see #302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants