Consider switching format_pattern to (String, Vec<Error>)

[zbraniecki]

Are you still planning to change the return value of format_pattern to (String, Option<Vec<Error>>)?

Originally posted by @stasm in #120

[stasm]

Related: we could also consider removing errors from the signature of format_pattern.

[zbraniecki]

Related: we could also consider removing errors from the signature of format_pattern.

What do you mean by that?

[stasm]

Since errors would be returned from format_pattern (wrapped in an Option), I think there's little use left for the third argument to format_pattern. We could thus change:

let value = bundle.format_pattern(&pattern, Some(&args), &mut errors);

to:

let (value, maybe_errors) = bundle.format_pattern(&pattern, Some(&args));

[zbraniecki]

Ah yes, that was my thinking as well!

[zbraniecki]

This gets moved to 0.8.