Skip to content

Commit 10aea85

Browse files
Ertanicalerque
authored andcommitted
refactor(fluent-syntax): Derive PartialEq, drop manual implementation
1 parent c4fa6ad commit 10aea85

File tree

2 files changed

+18
-262
lines changed

2 files changed

+18
-262
lines changed

fluent-syntax/src/ast/helper.rs

Lines changed: 1 addition & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@ use serde::{Deserialize, Serialize};
77
// This is a helper struct used to properly deserialize referential
88
// JSON comments which are single continuous String, into a vec of
99
// content slices.
10-
#[derive(Debug, Clone)]
11-
#[cfg_attr(not(feature = "spans"), derive(PartialEq, Eq))]
10+
#[derive(Debug, Clone, PartialEq)]
1211
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
1312
#[cfg_attr(feature = "serde", serde(untagged))]
1413
pub enum CommentDef<S> {
@@ -24,34 +23,6 @@ pub enum CommentDef<S> {
2423
},
2524
}
2625

27-
#[cfg(feature = "spans")]
28-
impl<S: Eq> Eq for CommentDef<S> {}
29-
30-
#[cfg(feature = "spans")]
31-
impl<S: PartialEq> PartialEq for CommentDef<S> {
32-
fn eq(&self, other: &Self) -> bool {
33-
match (self, other) {
34-
(
35-
Self::Single {
36-
content: l_content, ..
37-
},
38-
Self::Single {
39-
content: r_content, ..
40-
},
41-
) => l_content == r_content,
42-
(
43-
Self::Multi {
44-
content: l_content, ..
45-
},
46-
Self::Multi {
47-
content: r_content, ..
48-
},
49-
) => l_content == r_content,
50-
_ => false,
51-
}
52-
}
53-
}
54-
5526
impl<S> From<CommentDef<S>> for Comment<S> {
5627
fn from(input: CommentDef<S>) -> Self {
5728
match input {

0 commit comments

Comments
 (0)