Bugfix: possible nullptr dereference in texture sampler

kblaschke · kblaschke · commit bd9f68e199fa · 2026-02-15T23:34:10.000+01:00
Crashes in some rare cases, e.g. "martin - test random mosscity.milk"
diff --git a/src/libprojectM/Renderer/TextureSamplerDescriptor.cpp b/src/libprojectM/Renderer/TextureSamplerDescriptor.cpp
@@ -20,7 +20,7 @@ TextureSamplerDescriptor::TextureSamplerDescriptor(const std::shared_ptr<class T
 
 auto TextureSamplerDescriptor::Empty() const -> bool
 {
-    return m_texture->Empty();
+    return !m_texture || m_texture->Empty();
 }
 
 void TextureSamplerDescriptor::Bind(GLint unit, const Shader& shader) const

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ TextureSamplerDescriptor::TextureSamplerDescriptor(const std::shared_ptr<class T`
`20`	`20`
`21`	`21`	`auto TextureSamplerDescriptor::Empty() const -> bool`
`22`	`22`	`{`
`23`		`- return m_texture->Empty();`
	`23`	`+ return !m_texture \|\| m_texture->Empty();`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`void TextureSamplerDescriptor::Bind(GLint unit, const Shader& shader) const`