Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache DB should be aware of the concept of substores #975

Open
andaaron opened this issue Nov 8, 2022 · 0 comments
Open

Cache DB should be aware of the concept of substores #975

andaaron opened this issue Nov 8, 2022 · 0 comments
Assignees
Milestone

Comments

@andaaron
Copy link
Contributor

andaaron commented Nov 8, 2022

Currently the cache DB is separate per store (default store and substores each have their own separate cache DB files).
Ideally we should not have to manage this many DBs.

The reason they are separate is that we don't want to dedupe files placed on separate stores (for example default store and a substore). This is because they stores may be on separate partitions, which makes hardlinks unusable in this case. Or a store may be local and another S3.

If we had a concept of substore in the cache DB logic, and it would be capable of not deduping objects on separate stores, we could reuse the same DB.

If we used the same DB for all cache, then we could potentially use the same DB file also for repo DB and user DB, and manage a single DB.

@chofnar chofnar self-assigned this Nov 10, 2022
@chofnar chofnar removed their assignment Nov 23, 2022
@rchincha rchincha added this to the v2.0.0 milestone Nov 28, 2022
@chofnar chofnar self-assigned this Dec 2, 2022
@rchincha rchincha linked a pull request Jan 28, 2023 that will close this issue
@rchincha rchincha modified the milestones: v2.0.0, v2.0.1 Nov 1, 2023
@rchincha rchincha modified the milestones: v2.0.1, v2.1.0 Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants