security: remove node os from inline validation

Author: stevewesthoek

packages/cli/src/agent/command-runner.ts

@@ -712,7 +712,6 @@ function buildInlineNodeValidationSource(sourceRoot: string, cwd: string, userSo
   const realFsp = require('node:fs/promises');
   const path = require('node:path');
   const url = require('node:url');
-  const os = require('node:os');
   const realProcess = require('node:process');
   const ROOT = ${JSON.stringify(rootReal)};
   const CWD = ${JSON.stringify(cwdReal)};
@@ -831,7 +830,6 @@ function buildInlineNodeValidationSource(sourceRoot: string, cwd: string, userSo
     if (id === 'fs/promises') return safePromises;
     if (id === 'path') return path;
     if (id === 'url') return url;
-    if (id === 'os') return os;
     if (id === 'process') return safeProcess;
     fail('module ' + moduleId + ' is not allowlisted');
   };

scripts/verify-command-runner.ts

@@ -196,6 +196,15 @@ if (node20Available) {
   assert.equal(result.outputTruncated, true)
   assert.equal(result.reason, 'output_limit_exceeded')
 
+  result = await runSafeCommand({ ...exactBase, executable: 'node', args: ['-e', "require('node:os')"] })
+  assert.equal(result.status, 'failed')
+  assert.match(result.stderr, /module node:os is not allowlisted/)
+
+  result = await runSafeCommand({ ...exactBase, executable: 'node', args: ['-e', "console.log(JSON.stringify({platform:process.platform,arch:process.arch}))"] })
+  assert.equal(result.status, 'completed')
+  assert(result.stdout.includes(process.platform))
+  assert(result.stdout.includes(process.arch))
+
   result = await runSafeCommand({ ...exactBase, executable: 'node', args: ['-e', "require('node:child_process')"] })
   assert.equal(result.status, 'failed')
   assert.match(result.stderr, /module node:child_process is not allowlisted/)