`Inputfield::set()` and `Inputfield::___callUnknown()` can mistake settings for attributes

[JanRomero]

Hi,

this thread int the forums got me curious. Apparently by manually setting the required HTML5 attribute, you can shoot yourself in the foot: the required setting will no longer be settable, messing up validation.

This bug resides in two places:

• Inputfield::set()
• Inputfield::___callUnknown()

When called on to change the required setting, both methods first check if an attribute by that name exists, set the attribute and early-return.

I believe the methods should exclude required from the attribute check, especially since required() is explicitly mentioned as a method in the docs (line 118). But presumably similar issues can arise with other attributes, too.

Cheers

[ryancramerdesign]

Thanks @JanRomero I've pushed a fix for that. I also wanted to mention there's the requiredAttr property supported by fieldtypes that use it, that automatically sets required=required attribute when true.

[matjazpotocnik]

@JanRomero, can you close this if you're ok with the fix?