Skip to content

Commit 85a93b0

Browse files
committed
notes about #592 and pull #597
1 parent 52995b3 commit 85a93b0

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

core/src/processing/core/PShape.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1985,10 +1985,10 @@ static protected PImage parseBase64Image(String imagePath) {
19851985
String extension = parts[0].substring(11);
19861986
String encodedData = parts[1];
19871987

1988+
// Fix for https://github.com/processing/processing4/issues/592
19881989
// If a SVG image has an error, the base 64 will fail, but the browser will work.
1989-
// So we are sanitizing the values before reading it.
1990-
// If you have any questions, please, read this
1991-
// reference: https://www.prostdev.com/post/understanding-the-illegal-base64-character-error-java-groovy-and-mule-4-dw-2-0
1990+
// So we are sanitizing the values before reading it:
1991+
// https://www.prostdev.com/post/understanding-the-illegal-base64-character-error-java-groovy-and-mule-4-dw-2-0
19921992
Base64.Decoder decoder;
19931993
if (encodedData.contains("+") || encodedData.contains("/")) {
19941994
decoder = Base64.getDecoder();

core/todo.txt

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,18 +11,16 @@ X maybe https://github.com/processing/processing4/issues/487
1111
contribs
1212
X P3D & P2D window not showing on MacOS Ventura (thx @jaegonlee)
1313
X https://github.com/processing/processing4/issues/544
14+
X Loading SVG file gives Illegal base64 character 20 encoding error (worked in v3.5.4)
15+
X https://github.com/processing/processing4/issues/592
16+
X https://github.com/processing/processing4/pull/599
1417

1518
data
1619
X use choice() instead of random() for list classes
1720
X remove random(PApplet) since unlikely to be used/seems overkill
1821
X add choice() as a PApplet method for int values of random()
1922

2023

21-
contrib
22-
_ Loading SVG file gives Illegal base64 character 20 encoding error (worked in v3.5.4)
23-
_ https://github.com/processing/processing4/issues/592
24-
_ https://github.com/processing/processing4/issues/592
25-
2624
_ freeze on resize with Windows (even the default renderer)
2725
_ https://github.com/processing/processing4/issues/507
2826

0 commit comments

Comments
 (0)