Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add videos back to 2015 contributors conference #656

Open
davepagurek opened this issue Dec 5, 2024 · 4 comments
Open

Add videos back to 2015 contributors conference #656

davepagurek opened this issue Dec 5, 2024 · 4 comments
Assignees
Labels
Discussion Good First Issue Good for newcomers Help Wanted Extra attention is needed

Comments

@davepagurek
Copy link
Collaborator

Topic

Kate just pointed out that https://archive.p5js.org/community/contributors-conference-2015.html has some videos that are not present on https://p5js.org/events/contributors-conference-2015/. Maybe we can add those back?

@davepagurek
Copy link
Collaborator Author

We have a component to embed vimeo videos here https://github.com/processing/p5.js-website/blob/d7a6eaaf36a59d80f837a90f3652081cac5424e6/src/components/VimeoEmbed/index.astro that we could use, e.g. this for this video:

<VimeoEmbed id="129140298" />

@davepagurek davepagurek added Help Wanted Extra attention is needed Good First Issue Good for newcomers labels Dec 5, 2024
@Rishabh821
Copy link

Hi @davepagurek,

I’d like to work on this issue! I’ll locate the missing videos from the archive page and use the VimeoEmbed component to add them back to the event page.

Let me know if there are any specific guidelines or details I should follow.

Thanks!

@davepagurek
Copy link
Collaborator Author

Thanks @Rishabh821! I think we haven't tried using that component yet, so we can do whatever is simplest in order to get it working, like just stacking each video vertically on the page below the photos. Let me know if you run into any issues!

@Rishabh821
Copy link

@davepagurek,

I’ve completed the work for adding the missing videos to the Contributors Conference 2015 page. The PR is ready for review: Link to the PR)

Could you please take a look when you have a moment? Let me know if you need any changes or have any suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Good First Issue Good for newcomers Help Wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants