Skip to content

Refactor to Functional Components and Integrate Tailwind CSS #2599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
avengsum opened this issue Nov 13, 2023 · 4 comments
Closed

Refactor to Functional Components and Integrate Tailwind CSS #2599

avengsum opened this issue Nov 13, 2023 · 4 comments
Labels
Enhancement Improvement to an existing feature

Comments

@avengsum
Copy link

Increasing Access

so here are some points -
->Functional components are concise and enhance code readability.
->Simplifies the code structure, making it easier to maintain and debug.
->Facilitates the use of React Hooks for managing state and lifecycle events.
->Promotes a clean separation between stateful and stateless components.

this will help the new developer to understand our code more easily because nowadays functional components are used and it has became a modern-day practice for react developers so I think we should also move to functional components it will help new developers to understand our codebase easily

Feature enhancement details

this will make our code more readable and by adding a tailwind to our code base it will make developers understand and work more easily with the UI part and it will make our code base more modern

@avengsum avengsum added the Enhancement Improvement to an existing feature label Nov 13, 2023
@avengsum
Copy link
Author

so what do you think @lindapaiste should I start working on this?

and I know that we have already discussed tailwind but I can't stop myself

@Akhilbisht798
Copy link
Contributor

Hey I think we have a similar discussion about tailwind CSS on this project and I don't think people were favor on it. So maybe we need to discuss this.
But for function component I agree with you there are many advantages of functional component, and it is more new way writing react. There are many components in this project that are needed to be changed to function components. So it will be a long process.

@avengsum
Copy link
Author

@Akhilbisht798 but we have to start at some point. should I start working on functional components @lindapaiste

@lindapaiste
Copy link
Collaborator

Re: Tailwind - we decided against it
#2435

Re: function components - we have a lot of pending PRs covering this. We need to review and merge all of those PRs, which is a pain because it’s easy to create bugs when migrating code so we need to review everything very carefully. But the code is written so we do not need any additional PRs.
#2358

@lindapaiste lindapaiste closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants