Skip to content

File uploader bugs #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
catarak opened this issue Jul 20, 2016 · 8 comments
Closed

File uploader bugs #14

catarak opened this issue Jul 20, 2016 · 8 comments

Comments

@catarak
Copy link
Member

catarak commented Jul 20, 2016

In the current editor, I have begun to add media uploads. As this is a fairly complicated task, as it stands right now, it only works for:

  • jpg/jpeg, png, gif (single frame), and tif
  • If you put it in your JS files. Will not resolve media in HTML and CSS.
  • If you download the project as a zip, it will download the images.

Eventually you will be able to uploads fonts, videos, and so on, and will parse it in all file types, but for now, I think it's good enough for teaching basic p5.js.

@catarak catarak added this to the Sprint 08/25/2016 milestone Aug 18, 2016
@catarak
Copy link
Member Author

catarak commented Aug 18, 2016

Next step: uploading text files! I think I'll need to add a file limit size, especially for files types like .json, which can be really big, and those will get uploaded to S3 rather than to the mongo database.

@catarak catarak modified the milestones: Sprint 09/06/2016, Sprint 08/25/2016 Sep 1, 2016
@REAS
Copy link
Member

REAS commented Oct 23, 2016

I'm making a note that I don't think SVG uploading is working. This isn't mentioned in the first comment, but I'm assuming it hasn't be attempted yet.

@shiffman
Copy link
Member

To add to the pile of files that students are trying to upload to the editor, I had one working with loadModel() this morning that wanted to upload an OBJ file.

@catarak
Copy link
Member Author

catarak commented Oct 24, 2016

I can handle this file types no problem! I just need to whitelist them.

@catarak
Copy link
Member Author

catarak commented Oct 24, 2016

Just tried adding SVG's but I couldn't get it to work because of processing/p5.js/#1648. Obj files are now working though and deployed.

@catarak
Copy link
Member Author

catarak commented Nov 2, 2016

just added support for font files: .tff and .otf, deployed.

@REAS
Copy link
Member

REAS commented Nov 22, 2016

The interface makes it feel like more than one file can be uploaded at a time, for example to load three images with one drag into the box, but only one is uploading at a time.

@catarak catarak changed the title Media Uploads--very fragile! File uploader bugs Dec 2, 2016
@catarak
Copy link
Member Author

catarak commented Feb 23, 2017

i'm going to close this--there's a separate ticket for the UX for the uploader being confusing (#271), and if there are bugs this ticket can be reopened.

@catarak catarak closed this as completed Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants