Skip to content

Commit 9ffeb3c

Browse files
authored
Merge pull request #2465 from Sheikh-JamirAlam/develop-Shortcuts
Changed Shortcut format for better accessibility
2 parents dd22eda + 16c3aa3 commit 9ffeb3c

File tree

4 files changed

+14
-16
lines changed

4 files changed

+14
-16
lines changed

client/modules/IDE/components/Header/Nav.jsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -206,9 +206,7 @@ const ProjectMenu = () => {
206206
<NavDropdownMenu id="edit" title={t('Nav.Edit.Title')}>
207207
<NavMenuItem onClick={cmRef.current?.tidyCode}>
208208
{t('Nav.Edit.TidyCode')}
209-
<span className="nav__keyboard-shortcut">
210-
{metaKeyName}+{'\u21E7'}+F
211-
</span>
209+
<span className="nav__keyboard-shortcut">{metaKeyName}+Shift+F</span>
212210
</NavMenuItem>
213211
<NavMenuItem onClick={cmRef.current?.showFind}>
214212
{t('Nav.Edit.Find')}
@@ -233,7 +231,7 @@ const ProjectMenu = () => {
233231
<NavMenuItem onClick={() => dispatch(stopSketch())}>
234232
{t('Nav.Sketch.Stop')}
235233
<span className="nav__keyboard-shortcut">
236-
{'\u21E7'}+{metaKeyName}+Enter
234+
Shift+{metaKeyName}+Enter
237235
</span>
238236
</NavMenuItem>
239237
</NavDropdownMenu>

client/modules/IDE/components/Header/__snapshots__/Nav.unit.test.jsx.snap

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -537,7 +537,7 @@ exports[`Nav renders editor version for desktop 1`] = `
537537
<span
538538
class="nav__keyboard-shortcut"
539539
>
540-
⌃+⇧+F
540+
Ctrl+Shift+F
541541
</span>
542542
</button>
543543
</li>
@@ -549,7 +549,7 @@ exports[`Nav renders editor version for desktop 1`] = `
549549
<span
550550
class="nav__keyboard-shortcut"
551551
>
552-
+F
552+
Ctrl+F
553553
</span>
554554
</button>
555555
</li>
@@ -561,7 +561,7 @@ exports[`Nav renders editor version for desktop 1`] = `
561561
<span
562562
class="nav__keyboard-shortcut"
563563
>
564-
+H
564+
Ctrl+H
565565
</span>
566566
</button>
567567
</li>
@@ -607,7 +607,7 @@ exports[`Nav renders editor version for desktop 1`] = `
607607
<span
608608
class="nav__keyboard-shortcut"
609609
>
610-
+Enter
610+
Ctrl+Enter
611611
</span>
612612
</button>
613613
</li>
@@ -619,7 +619,7 @@ exports[`Nav renders editor version for desktop 1`] = `
619619
<span
620620
class="nav__keyboard-shortcut"
621621
>
622-
⇧+⌃+Enter
622+
Shift+Ctrl+Enter
623623
</span>
624624
</button>
625625
</li>

client/modules/IDE/components/KeyboardShortcutModal.jsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ function KeyboardShortcutModal() {
2525
<ul className="keyboard-shortcuts__list">
2626
<li className="keyboard-shortcut-item">
2727
<span className="keyboard-shortcut__command">
28-
{metaKeyName} + {'\u21E7'} + F
28+
{metaKeyName} + Shift + F
2929
</span>
3030
<span>{t('KeyboardShortcuts.CodeEditing.Tidy')}</span>
3131
</li>
@@ -39,7 +39,7 @@ function KeyboardShortcutModal() {
3939
</li>
4040
<li className="keyboard-shortcut-item">
4141
<span className="keyboard-shortcut__command">
42-
{metaKeyName} + {'\u21E7'} + G
42+
{metaKeyName} + Shift + G
4343
</span>
4444
<span>
4545
{t('KeyboardShortcuts.CodeEditing.FindPreviousTextMatch')}
@@ -84,24 +84,24 @@ function KeyboardShortcutModal() {
8484
</li>
8585
<li className="keyboard-shortcut-item">
8686
<span className="keyboard-shortcut__command">
87-
{metaKeyName} + {'\u21E7'} + Enter
87+
{metaKeyName} + Shift + Enter
8888
</span>
8989
<span>{t('KeyboardShortcuts.General.StopSketch')}</span>
9090
</li>
9191
<li className="keyboard-shortcut-item">
9292
<span className="keyboard-shortcut__command">
93-
{metaKeyName} + {'\u21E7'} + 1
93+
{metaKeyName} + Shift + 1
9494
</span>
9595
<span>{t('KeyboardShortcuts.General.TurnOnAccessibleOutput')}</span>
9696
</li>
9797
<li className="keyboard-shortcut-item">
9898
<span className="keyboard-shortcut__command">
99-
{metaKeyName} + {'\u21E7'} + 2
99+
{metaKeyName} + Shift + 2
100100
</span>
101101
<span>{t('KeyboardShortcuts.General.TurnOffAccessibleOutput')}</span>
102102
</li>
103103
<li className="keyboard-shortcut-item">
104-
<span className="keyboard-shortcut__command">{'\u21E7'} + Right</span>
104+
<span className="keyboard-shortcut__command">Shift + Right</span>
105105
<span>Go to Reference for Selected Item in Hinter</span>
106106
</li>
107107
</ul>

client/utils/metaKey.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@ const metaKey = (() => {
66
return 'Ctrl';
77
})();
88

9-
const metaKeyName = metaKey === 'Cmd' ? '⌘' : '';
9+
const metaKeyName = metaKey === 'Cmd' ? '⌘' : 'Ctrl';
1010

1111
export { metaKey, metaKeyName };

0 commit comments

Comments
 (0)