This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Fix circuits integration tests panic: "unwrap on None value" when EIP-4896 withdrawals==None#1688
Merged
AronisAt79 merged 1 commit intomainfrom Nov 27, 2023
Merged
Conversation
ChihChengLiang
approved these changes
Nov 27, 2023
Contributor
Author
|
Thanks @ChihChengLiang . Yes the unwrap_or_default clears the error so if this solution is acceptable, we can merge this fix. I would like though to have another review from @KimiWu123 cause integration tests still fail down the process. evm and super circuit tests fail for erc20_openzeppelin_transfers with panic just to make sure this failure is not somehow logically associated to the fix provided with this PR. If so, we can take care of the new panic with a new issue :) |
KimiWu123
approved these changes
Nov 27, 2023
Contributor
KimiWu123
left a comment
There was a problem hiding this comment.
LGTM! Thanks for your fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Integration Tests have been failing since introduction of #1369, due to Option::Unwrap on None value, when eth_block.withdrawals==None.
Type of change
Contents
Rationale
replace eth_block.withdrawals.clone().unwrap() with eth_block.withdrawals.clone().unwrap_or_default()
How Has This Been Tested?
https://github.com/privacy-scaling-explorations/zkevm-circuits/actions/runs/6968928576/job/18963801769
Issue
#1687