evm: a lot of opcode gadgets need to be updated with `CellType::StoragePhase2`

[lispc]

eg: gas_price cell should be a phase2 cell.

zkevm-circuits/zkevm-circuits/src/evm_circuit/execution/gasprice.rs

Lines 80 to 81 in f7941c1

	self.gas_price
	.assign(region, offset, region.word_rlc(gas_price))?;

[lispc]

modify MockProver to catch these types of errors.

scroll-tech/halo2@e409a69

yeah a lot of tests failed.

[ed255]

We would like to address replacing all the word_rlc usage by word hi/lo very soon (probably in the coming weeks). For this reason we haven't been very thorough with correctness/soundness reviews and analysis related to the usage of the Challange API. And I think we won't focus too much on fixing these issues ourselves until the word hi/lo is implemented (which will remove a lot of Challenge API usage). Having said that, any fix related to these issue will be welcome and reviewed!

[lispc]

i think hi-lo cannot solve all the challenge API problem? It can solve evm_word and. lookup_input randomness, but will you plan to also remove the dynamic length keccak_input randomness?

We did some experiment earlier but did not continue finishing it

scroll-tech#216

btw jonathan made more improvements based on our version

https://github.com/jonathanpwang/zkevm-circuits/tree/keccak-only-subtree

[ed255]

i think hi-lo cannot solve all the challenge API problem? It can solve evm_word and. lookup_input randomness, but will you plan to also remove the dynamic length keccak_input randomness?

Definitely, word hi-lo will not solve all Challenge API problems, but hopefully it solves many of them (and reduces some circuit complexity). Our current plan is to keep using the challenge API (via RLC) for the lookups in EVM Circuit and the dynamic length keccak inputs.

We did some experiment earlier but did not continue finishing it

scroll-tech#216

btw jonathan made more improvements based on our version

https://github.com/jonathanpwang/zkevm-circuits/tree/keccak-only-subtree

Interesting! Thanks for sharing these links!