Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button: size inconsistent #6072

Closed
ghost opened this issue Jul 17, 2024 · 1 comment
Closed

Button: size inconsistent #6072

ghost opened this issue Jul 17, 2024 · 1 comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@ghost
Copy link

ghost commented Jul 17, 2024

Describe the bug

Icon-only buttons do not properly change their rendered size when using the size prop.

As you can see, when using the Lara theme, in v4 syled mode the rounded icon-only buttons have the same size regardless of the value of the size prop.

In v3 styled mode, the rounded and rectangular size="large" icon-only buttons are a little bit wider than the other icon-only buttons.

In v3 unstyled mode, the rounded icon-only buttons do actually differ in size, but only the height changes. Of course rounded icon-only buttons should always resemble a perfect circle, not an egg.

Also in v3 unstyled mode, both rounded and rectangular size="small" icon-only buttons have a different height compared to their labeled counterparts. They are slightly taller than the size="small" ones with a label.

TL;DR:

The height of icon-only buttons should not differ compared to labeled buttons with the same size. Because they are icon-only Buttons, they should also have their width set to the same value as the height, resulting in rectangular Buttons resembling a square and rounded Buttons resembling a circle.

v4 styled

buttons-v4-styled

v3 styled

buttons-v3-styled

v3 unstyled

buttons-v3-unstyled

Reproducer

https://stackblitz.com/~/github.com/Peanut4287/buttons-v4-styled
https://stackblitz.com/~/github.com/Peanut4287/buttons-v3-styled
https://stackblitz.com/~/github.com/Peanut4287/buttons-v3-unstyled

PrimeVue version

3 & 4

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

Chrome, Firefox

@ghost ghost added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 17, 2024
@cagataycivici
Copy link
Member

cagataycivici commented Dec 27, 2024

Tracked at #7017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

1 participant