Skip to content

Commit 0f3fe13

Browse files
authored
Merge pull request #912 from prezly/feature/care-5047-make-lena-collapse-into-mobile-header-sooner-same-as-bea
[CARE-5047] Fix - Replicate responsive behaviour from Bea
2 parents 66da352 + 57fc20d commit 0f3fe13

7 files changed

Lines changed: 10 additions & 23 deletions

File tree

components/RichText/styles.module.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
.htmlContent h1 {
2424
@include heading-2;
2525

26-
@include desktop-large-up {
26+
@include desktop-up {
2727
@include heading-1;
2828
}
2929

@@ -39,7 +39,7 @@
3939
.htmlContent h2 {
4040
@include heading-3;
4141

42-
@include desktop-large-up {
42+
@include desktop-up {
4343
@include heading-2;
4444
}
4545

components/StoryCards/HighlightedStoryCard.module.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
@include heading-2;
5454
@include ensure-max-text-height(4, $line-height-m);
5555

56-
@include desktop-large-up {
56+
@include desktop-up {
5757
@include heading-1-xxl;
5858
@include ensure-max-text-height(2, $line-height-xl);
5959
}

modules/Story/HeaderRenderer/HeaderRenderer.module.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
.prezly-slate-heading--heading-1 {
55
@include heading-2;
66

7-
@include desktop-large-up {
7+
@include desktop-up {
88
@include heading-1;
99
}
1010

styles/mixins/_container.scss

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,6 @@
1515
padding-right: $grid-spacing-desktop;
1616
max-width: $grid-container-max-width;
1717
}
18-
19-
@include desktop-large-up {
20-
padding-left: $grid-spacing-desktop-large;
21-
padding-right: $grid-spacing-desktop-large;
22-
}
2318
}
2419

2520
/*

styles/mixins/_responsive.scss

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,25 @@
11
@import "../variables/breakpoints";
22

33
@mixin mobile-only {
4-
@media screen and (max-width: $breakpoint-tablet) {
4+
@media screen and (max-width: $breakpoint-tablet - 1px) {
55
@content;
66
}
77
}
88

99
@mixin tablet-up {
10-
@media screen and (min-width: $breakpoint-tablet + 1px) {
10+
@media screen and (min-width: $breakpoint-tablet) {
1111
@content;
1212
}
1313
}
1414

1515
@mixin tablet-only {
16-
@media screen and (min-width: $breakpoint-tablet + 1px) and (max-width: $breakpoint-desktop) {
16+
@media screen and (min-width: $breakpoint-tablet) and (max-width: $breakpoint-desktop) {
1717
@content;
1818
}
1919
}
2020

2121
@mixin desktop-up {
22-
@media screen and (min-width: $breakpoint-desktop + 1px) {
23-
@content;
24-
}
25-
}
26-
27-
@mixin desktop-large-up {
28-
@media screen and (min-width: $breakpoint-desktop-large + 1px) {
22+
@media screen and (min-width: $breakpoint-desktop) {
2923
@content;
3024
}
3125
}

styles/variables/_breakpoints.scss

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
$breakpoint-tablet: 414px;
2-
$breakpoint-desktop: 768px;
3-
$breakpoint-desktop-large: 1024px;
1+
$breakpoint-tablet: 768px;
2+
$breakpoint-desktop: 1024px;
43
$breakpoint-cards-small: 600px;
54
$breakpoint-cards-medium: 940px;

styles/variables/_spacing.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,5 @@ $grid-gutter-tablet: 2.5rem; // 40px
1919
$grid-spacing-tablet: 2.5rem; // 40px
2020
$grid-gutter-desktop: 2.5rem; // 40px
2121
$grid-spacing-desktop: 2.5rem; // 40px
22-
$grid-spacing-desktop-large: 5rem; // 80px
2322

2423
$grid-container-max-width: 1280px; // 1120px + 80px spacing on the sides

0 commit comments

Comments
 (0)