feat(unix): centralize Unix integration service in @agor/core #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves Unix user/group/symlink management to packages/core for shared use by CLI and daemon. Introduces CommandExecutor abstraction for privilege escalation. Key changes: - Add CommandExecutor interface with DirectExecutor, SudoCliExecutor, NoOpExecutor - Add UnixIntegrationService with worktree groups, user management, symlinks - Add user-manager.ts with Unix user utilities and command strings - Add symlink-manager.ts with symlink utilities for worktree access - Refactor daemon to use core service via factory pattern - Wire up hooks in worktree-owners for auto group membership - Wire up hooks in users service for auto Unix user creation - Add CLI admin commands: ensure-user, delete-user, create/remove-symlink, sync-user-symlinks 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
mistercrunch
force-pushed
the
rbac-admin-sudo
branch
from
3cabc2d to
2db2257
Compare
5 tasks
- Add AGOR_USERS_GROUP constant for managed user identification - Add ensureAgorUsersGroup() to create group if not exists - Add addUserToAgorUsersGroup/removeUserFromAgorUsersGroup methods - Add isAgorManagedUser() to check group membership - ensureUnixUser now adds users to agor_users group - deleteUnixUser now removes users from agor_users group This enables natural usernames (max instead of agor_max) while maintaining security containment - daemon can only impersonate users that are members of the agor_users group. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Adds comprehensive documentation for running Agor in full multiplayer mode with Unix-level isolation: - Overview of shared development environments and isolation benefits - Security considerations (daemon privileges, API key exposure) - Recommendations (VPN, trusted users, key rotation) - Setup guide: PostgreSQL, volumes, sudoers, observability - Permission levels reference (view/prompt/all) - Troubleshooting common issues 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Add resolveUnixUserForImpersonation() for centralized mode-aware logic - Add validateResolvedUnixUser() for user existence validation - Refactor terminals.ts and index.ts to use centralized utilities - Add comprehensive unit tests (111 tests) for Unix utilities: - user-manager.test.ts: username gen/parse, validation, impersonation - group-manager.test.ts: group names, permissions, command builders - symlink-manager.test.ts: paths, symlink info, command builders The impersonation logic now consistently handles all 4 Unix user modes (simple, insulated, opportunistic, strict) across terminal sessions and executor spawning. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Remove CLI executor mode (not wired up, SudoCliExecutor expects `agor admin` subcommands that don't exist yet) - Fix env file permissions: chown to impersonated user so they can source the file (was 0600 owned by daemon, unreadable after sudo -u) - Pass homeBase to UnixUserCommands.createUser() so user homes are created in configured location, not always /home 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
mistercrunch
force-pushed
the
rbac-admin-sudo
branch
from
3554047 to
9efd5f4
Compare
- Remove SSH port exposure (use docker exec + sudo su instead) - Add comment explaining how to test as alice/bob - Wait for db type definitions in entrypoint (needed for migrations) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
packages/corefor shared use by CLI and daemonCommandExecutorabstraction to handle privilege escalation (direct CLI vs sudo-based daemon)Changes
Core Package (
packages/core/src/unix/)command-executor.ts-CommandExecutorinterface withDirectExecutor,SudoCliExecutor,NoOpExecutoruser-manager.ts- Unix user utilities (generateUnixUsername(),UnixUserCommands)symlink-manager.ts- Symlink utilities (SymlinkCommands,getWorktreeSymlinkPath())unix-integration-service.ts- Main orchestration service with:createWorktreeGroup,deleteWorktreeGroup,addUserToWorktreeGroup,removeUserFromWorktreeGroupensureUnixUser,deleteUnixUsercreateWorktreeSymlink,removeWorktreeSymlink,syncUserSymlinkssyncWorktree,syncUser,syncAllCLI Admin Commands
admin ensure-user- Create Unix user if doesn't existadmin delete-user- Delete Unix useradmin create-symlink- Create worktree symlink in user homeadmin remove-symlink- Remove worktree symlinkadmin sync-user-symlinks- Clean up broken symlinksDaemon Integration
unix-integration.tsto re-export from core withSudoCliExecutorapp.set('unixIntegration', service)for cross-service accessworktree-ownersfor auto group membershipusersfor auto Unix user creation whenunix_usernameis setTest plan
execution.worktree_rbac: trueconfigunix_usernamecreates Unix user🤖 Generated with Claude Code