test: target-specific dependencies (#65)

lucascolley · remimimimimi · Hofer-Julian · web-flow · commit dc03e6ff94ea · 2025-09-22T10:44:13.000+02:00
Co-authored-by: remimimimimi &lt;remimimimimi@protonmail.com&gt;
Co-authored-by: Julian Hofer &lt;julianhofer@gnome.org&gt;
diff --git a/pixi.toml b/pixi.toml
@@ -22,7 +22,7 @@ python-dotenv = ">=1.1.0,<2"
 pyyaml = ">=6.0.2,<7"
 rich = ">=14,<15"
 syrupy = ">=4.8.0,<5"
-tomli-w = ">=1.0,<2"
+tomli-w = ">=1.2.0,<2"
 types-pyyaml = ">=6.0.12.20241230,<7"
 
 
diff --git a/tests/data/channels/channels/target_specific_channel_1/linux-64/package-unix-0.1.0-hb0f4dca_0.conda b/tests/data/channels/channels/target_specific_channel_1/linux-64/package-unix-0.1.0-hb0f4dca_0.conda
diff --git a/tests/data/channels/channels/target_specific_channel_1/linux-64/repodata.json b/tests/data/channels/channels/target_specific_channel_1/linux-64/repodata.json
@@ -0,0 +1 @@
+{"info":{"subdir":"linux-64"},"packages":{},"packages.conda":{"package-unix-0.1.0-hb0f4dca_0.conda":{"arch":"x86_64","build":"hb0f4dca_0","build_number":0,"depends":[],"md5":"fe8e916dec98da10345b8f085bccb264","name":"package-unix","platform":"linux","sha256":"edfe4c21fb3902b6bb508f1b5d421d5d5e1ca50e6c5aa0ad2bf336643cc21977","size":1193,"subdir":"linux-64","timestamp":1758206539718,"version":"0.1.0"}},"repodata_version":2}
diff --git a/tests/data/channels/channels/target_specific_channel_1/noarch/repodata.json b/tests/data/channels/channels/target_specific_channel_1/noarch/repodata.json
@@ -0,0 +1 @@
+{"info":{"subdir":"noarch"},"packages":{},"packages.conda":{},"repodata_version":2}
diff --git a/tests/data/channels/channels/target_specific_channel_1/osx-64/package-unix-0.1.0-h0dc7051_0.conda b/tests/data/channels/channels/target_specific_channel_1/osx-64/package-unix-0.1.0-h0dc7051_0.conda
diff --git a/tests/data/channels/channels/target_specific_channel_1/osx-64/repodata.json b/tests/data/channels/channels/target_specific_channel_1/osx-64/repodata.json
@@ -0,0 +1 @@
+{"info":{"subdir":"osx-64"},"packages":{},"packages.conda":{"package-unix-0.1.0-h0dc7051_0.conda":{"arch":"x86_64","build":"h0dc7051_0","build_number":0,"depends":[],"md5":"7d3d6fcc9b7dc445c757f8ad91df61e9","name":"package-unix","platform":"osx","sha256":"8073279890f536c661095ba8a2c51fab76ce753fbc6fe4da71a1d39d06870db0","size":1190,"subdir":"osx-64","timestamp":1758206539846,"version":"0.1.0"}},"repodata_version":2}
diff --git a/tests/data/channels/channels/target_specific_channel_1/osx-arm64/package-unix-0.1.0-h60d57d3_0.conda b/tests/data/channels/channels/target_specific_channel_1/osx-arm64/package-unix-0.1.0-h60d57d3_0.conda
diff --git a/tests/data/channels/channels/target_specific_channel_1/osx-arm64/repodata.json b/tests/data/channels/channels/target_specific_channel_1/osx-arm64/repodata.json
@@ -0,0 +1 @@
+{"info":{"subdir":"osx-arm64"},"packages":{},"packages.conda":{"package-unix-0.1.0-h60d57d3_0.conda":{"arch":"arm64","build":"h60d57d3_0","build_number":0,"depends":[],"md5":"666d4cf9f24b4380384650010a7b0c9d","name":"package-unix","platform":"osx","sha256":"85307f59901c916eba805e421137442b5dfd46132e82967bbca2a3301afc3db9","size":1190,"subdir":"osx-arm64","timestamp":1758206539781,"version":"0.1.0"}},"repodata_version":2}
diff --git a/tests/data/channels/channels/target_specific_channel_1/win-64/package-windows-0.1.0-h9490d1a_0.conda b/tests/data/channels/channels/target_specific_channel_1/win-64/package-windows-0.1.0-h9490d1a_0.conda
diff --git a/tests/data/channels/channels/target_specific_channel_1/win-64/repodata.json b/tests/data/channels/channels/target_specific_channel_1/win-64/repodata.json
@@ -0,0 +1 @@
+{"info":{"subdir":"win-64"},"packages":{},"packages.conda":{"package-windows-0.1.0-h9490d1a_0.conda":{"arch":"x86_64","build":"h9490d1a_0","build_number":0,"depends":[],"md5":"877213089d017ad722ebf5cf0b3395f8","name":"package-windows","platform":"win","sha256":"ac1f08cf41d2954126bf8da686e605d609eba87d93e457d0129cac0f1641eb58","size":1209,"subdir":"win-64","timestamp":1758206539651,"version":"0.1.0"}},"repodata_version":2}
diff --git a/tests/data/channels/mappings.toml b/tests/data/channels/mappings.toml
@@ -1,3 +1,4 @@
 "dummy_channel_1.yaml" = "dummy_channel_1"
 "multiple_versions_channel_1_010.yaml" = "multiple_versions_channel_1"
 "multiple_versions_channel_1_020.yaml" = "multiple_versions_channel_1"
+"target_specific_channel_1.yaml" = "target_specific_channel_1"
diff --git a/tests/data/channels/recipes/target_specific_channel_1.yaml b/tests/data/channels/recipes/target_specific_channel_1.yaml
@@ -0,0 +1,23 @@
+outputs:
+  - package:
+      name: package-unix
+      version: 0.1.0
+
+    build:
+      skip: not unix
+      script:
+        - mkdir -p $PREFIX/bin
+        - echo "#!/usr/bin/env bash" > $PREFIX/bin/package
+        - echo "echo unix" >> $PREFIX/bin/package
+        - chmod +x $PREFIX/bin/package
+
+  - package:
+      name: package-windows
+      version: 0.1.0
+
+    build:
+      skip: not win
+      script:
+        - mkdir -p $PREFIX/bin
+        - echo "@echo off" > $PREFIX/bin/package.bat
+        - echo "echo windows" >> $PREFIX/bin/package.bat
diff --git a/tests/data/pixi_build/target-specific/foo/__init__.py b/tests/data/pixi_build/target-specific/foo/__init__.py
@@ -0,0 +1,2 @@
+def main() -> None:
+    print("Build backend works")
diff --git a/tests/data/pixi_build/target-specific/pixi.toml b/tests/data/pixi_build/target-specific/pixi.toml
@@ -0,0 +1,25 @@
+[workspace]
+channels = [
+  "https://prefix.dev/pixi-build-backends",
+  "https://prefix.dev/conda-forge",
+]
+platforms = ["osx-arm64", "linux-64", "osx-64", "win-64"]
+preview = ["pixi-build"]
+
+[package]
+name = "foo"
+version = "0.1.0"
+
+[package.build.backend]
+name = "pixi-build-python"
+version = "*"
+
+[package.host-dependencies]
+hatchling = "*"
+
+# Add packages that would be unavailable for the wrong target
+[package.target.unix.host-dependencies]
+package-unix = "*"
+
+[package.target.win-64.host-dependencies]
+package-windows = "*"
diff --git a/tests/data/pixi_build/target-specific/pyproject.toml b/tests/data/pixi_build/target-specific/pyproject.toml
@@ -0,0 +1,8 @@
+[project]
+name = "foo"
+requires-python = ">= 3.11"
+version = "0.1.0"
+
+[build-system]
+build-backend = "hatchling.build"
+requires = ["hatchling"]
diff --git a/tests/integration_python/conftest.py b/tests/integration_python/conftest.py
@@ -215,3 +215,8 @@ def dummy_channel_1(channels: Path) -> str:
 @pytest.fixture
 def multiple_versions_channel_1(channels: Path) -> str:
     return channels.joinpath("multiple_versions_channel_1").as_uri()
+
+
+@pytest.fixture
+def target_specific_channel_1(channels: Path) -> str:
+    return channels.joinpath("target_specific_channel_1").as_uri()
diff --git a/tests/integration_python/test_build.py b/tests/integration_python/test_build.py
@@ -2,6 +2,8 @@
 from pathlib import Path
 
 import pytest
+import tomli_w
+import tomllib
 
 from .common import CURRENT_PLATFORM, ExitCode, Workspace, verify_cli_command
 
@@ -532,3 +534,26 @@ def test_extra_args(pixi: Path, build_data: Path, tmp_pixi_workspace: Path) -> N
         ],
     )
     assert target_dir.joinpath("src", "mybuilddir", "build.ninja").is_file()
+
+
+def test_target_specific_dependency(
+    pixi: Path, build_data: Path, tmp_pixi_workspace: Path, target_specific_channel_1: str
+) -> None:
+    """
+    Check that target-specific dependencies are not solved for on other targets.
+    Regression test for prefix-dev/pixi#4542.
+    """
+    project = "target-specific"
+    test_data = build_data.joinpath(project)
+
+    target_dir = tmp_pixi_workspace.joinpath(project)
+    shutil.copytree(test_data, target_dir)
+    manifest_path = target_dir.joinpath("pixi.toml")
+
+    manifest = tomllib.loads(manifest_path.read_text())
+    manifest["workspace"]["channels"] += [target_specific_channel_1]
+    manifest_path.write_text(tomli_w.dumps(manifest))
+
+    verify_cli_command(
+        [pixi, "build", "--manifest-path", manifest_path, "--output-dir", tmp_pixi_workspace],
+    )

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+{"info":{"subdir":"linux-64"},"packages":{},"packages.conda":{"package-unix-0.1.0-hb0f4dca_0.conda":{"arch":"x86_64","build":"hb0f4dca_0","build_number":0,"depends":[],"md5":"fe8e916dec98da10345b8f085bccb264","name":"package-unix","platform":"linux","sha256":"edfe4c21fb3902b6bb508f1b5d421d5d5e1ca50e6c5aa0ad2bf336643cc21977","size":1193,"subdir":"linux-64","timestamp":1758206539718,"version":"0.1.0"}},"repodata_version":2}`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+{"info":{"subdir":"noarch"},"packages":{},"packages.conda":{},"repodata_version":2}`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+{"info":{"subdir":"osx-64"},"packages":{},"packages.conda":{"package-unix-0.1.0-h0dc7051_0.conda":{"arch":"x86_64","build":"h0dc7051_0","build_number":0,"depends":[],"md5":"7d3d6fcc9b7dc445c757f8ad91df61e9","name":"package-unix","platform":"osx","sha256":"8073279890f536c661095ba8a2c51fab76ce753fbc6fe4da71a1d39d06870db0","size":1190,"subdir":"osx-64","timestamp":1758206539846,"version":"0.1.0"}},"repodata_version":2}`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+{"info":{"subdir":"osx-arm64"},"packages":{},"packages.conda":{"package-unix-0.1.0-h60d57d3_0.conda":{"arch":"arm64","build":"h60d57d3_0","build_number":0,"depends":[],"md5":"666d4cf9f24b4380384650010a7b0c9d","name":"package-unix","platform":"osx","sha256":"85307f59901c916eba805e421137442b5dfd46132e82967bbca2a3301afc3db9","size":1190,"subdir":"osx-arm64","timestamp":1758206539781,"version":"0.1.0"}},"repodata_version":2}`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+{"info":{"subdir":"win-64"},"packages":{},"packages.conda":{"package-windows-0.1.0-h9490d1a_0.conda":{"arch":"x86_64","build":"h9490d1a_0","build_number":0,"depends":[],"md5":"877213089d017ad722ebf5cf0b3395f8","name":"package-windows","platform":"win","sha256":"ac1f08cf41d2954126bf8da686e605d609eba87d93e457d0129cac0f1641eb58","size":1209,"subdir":"win-64","timestamp":1758206539651,"version":"0.1.0"}},"repodata_version":2}`