Skip to content

Conversation

@j-signorelli
Copy link
Contributor

@j-signorelli j-signorelli commented Oct 11, 2025

This PR is a follow-up to fixes in the SU2 adapter outlined at precice/su2-adapter#47, where time iteration and time increment is made consistent with the SU2 source code, along with using the preferred/better approach of using a restart file for the initial condition.

An initial condition is added and the config file is updated accordingly.

Checklist:

  • I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@MakisH MakisH self-requested a review October 12, 2025 09:19
@MakisH MakisH self-assigned this Oct 12, 2025
@MakisH
Copy link
Member

MakisH commented Jan 12, 2026

@j-signorelli thanks for the PR! Could you please write a sentence here (or directly in the README.md of the tutorial) on how the initial flow file has been created?

Note to self: even though the system tests pass, they actually don't yet cover this case (flow-over-heated-plate with SU2).

@j-signorelli
Copy link
Contributor Author

Had to do some digging... The initial flow file was generated using the attached config file, solving for the adiabatic steady-state flow:

laminar_config_steady.cfg.txt

Unfortunately I have no recollection why I did this... Maybe it was to have a flowfield that satisfies the BCs as the IC?

It looks like to me that the OpenFOAM IC uses just a uniform flow as the IC (is this correct?) so at first glance it makes more sense to use this instead. I will look into this.

@MakisH
Copy link
Member

MakisH commented Jan 13, 2026

Thanks for the update! Clearly, starting from a better initial state is better.

With the risk of contradicting myself (we already had a similar discussion for the perpendicular-flap in #612), I would say let's go for the initialized flow, provided that we document how we got it and how to start from an uninitialized flow, if needed. In this tutorial, we only have SU2 and OpenFOAM as flow solvers, and doing the same in OpenFOAM is very easy, e.g., with potentialFoam (I can do it).

I did some comparisons:

Figure_1

We could also link to this page: https://su2code.github.io/docs_v7/Restart-File/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants