Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keycloak.json property not consistent with other Pravega Keycloak Integrations #380

Open
maddisondavid opened this issue Jul 8, 2022 · 0 comments

Comments

@maddisondavid
Copy link

Problem description
The Rust client uses the pravega_client_auth_keycloak property for the location of the keycloak.json file, however, this is not consistent with existing Pravega Keycloak integrations such as the Java Pravega Keycloak plugin Keycloak plugin https://github.com/pravega/pravega-keycloak which use KEYCLOAK_SERVICE_ACCOUNT_FILE.

The result is that systems configured with the environment for Pravega must be modified in order to use the Python bindings.

Problem location

let path = ret_val.get(AUTH_KEYCLOAK_PATH).expect("get keycloak json file");

Suggestions for an improvement
The Rust client should also support the KEYCLOAK_SERVICE_ACCOUNT_FILE as well as pravega_client_auth_keycloak in order to be consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant