Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement visual appearance of beatmap submission wizard #31784

Merged
merged 5 commits into from
Feb 5, 2025

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Feb 4, 2025

2025-02-04.09-07-20.mp4

@pull-request-size pull-request-size bot added size/L and removed size/XL labels Feb 4, 2025
@godkama
Copy link

godkama commented Feb 4, 2025

Shouldn't this also require the text field to enter the description?

@bdach
Copy link
Collaborator Author

bdach commented Feb 4, 2025

The description will not be editable via the lazer client because of the overhead of implementing bbcode parsing and preview into the client (and also we still don't have a workable multiline textbox....) The website will take that role for lazer submissions.

@godkama
Copy link

godkama commented Feb 4, 2025

i see. then maybe for a first time submission force the user onto the beatmap page and show a textbox that tells the user they can edit it onsite?

@bdach
Copy link
Collaborator Author

bdach commented Feb 4, 2025

The "load in browser after submission" checkbox is already checked by default on the last step of the wizard (can be switched off if someone finds it annoying, setting persists to local config). Not really sure anything more is necessary.

@peppy peppy merged commit 9b79cf6 into ppy:master Feb 5, 2025
10 checks passed
@bdach bdach deleted the bss/wizard-appearance branch February 5, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants