Merge pull request #33 from bdach/file-upload-limits

Bump incoming file size limit to 200MB

Author: peppy

osu.Server.BeatmapSubmission/BeatmapSubmissionController.cs

@@ -199,10 +199,6 @@ public async Task<IActionResult> PutBeatmapSetAsync([FromBody] PutBeatmapSetRequ
         [EnableRateLimiting(Program.RATE_LIMIT_POLICY)]
         public async Task<IActionResult> UploadFullPackageAsync(
             [FromRoute] uint beatmapSetId,
-            // TODO: this won't fly on production, biggest existing beatmap archives exceed buffering limits (`MultipartBodyLengthLimit` = 128MB specifically)
-            // potentially also https://github.com/aspnet/Announcements/issues/267
-            // see: https://learn.microsoft.com/en-us/aspnet/core/mvc/models/file-uploads?view=aspnetcore-8.0#small-and-large-files
-            // needs further testing
             IFormFile beatmapArchive)
         {
             uint userId = User.GetUserId();

osu.Server.BeatmapSubmission/Program.cs

@@ -3,6 +3,7 @@
 using System.Threading.RateLimiting;
 using JetBrains.Annotations;
 using Microsoft.AspNetCore.Authentication.JwtBearer;
+using Microsoft.AspNetCore.Http.Features;
 using Microsoft.AspNetCore.HttpLogging;
 using Microsoft.Extensions.Options;
 using osu.Server.BeatmapSubmission.Authentication;
@@ -17,7 +18,7 @@ namespace osu.Server.BeatmapSubmission
     public class Program
     {
         public const string RATE_LIMIT_POLICY = "SlidingWindowRateLimiter";
-
+        public const int ABSOLUTE_REQUEST_SIZE_LIMIT_BYTES = 200_000_000;
         public const string INTEGRATION_TEST_ENVIRONMENT = "IntegrationTest";
 
         public static void Main(string[] args)
@@ -169,6 +170,9 @@ public static void Main(string[] args)
                 });
             }
 
+            builder.WebHost.ConfigureKestrel(options => options.Limits.MaxRequestBodySize = ABSOLUTE_REQUEST_SIZE_LIMIT_BYTES);
+            builder.Services.Configure<FormOptions>(options => options.MultipartBodyLengthLimit = ABSOLUTE_REQUEST_SIZE_LIMIT_BYTES);
+
             var app = builder.Build();
 
             if (app.Environment.IsDevelopment())