Skip to content

Commit 0e05c17

Browse files
committed
fix: surface port-forward errors instead of generic timeout
1 parent 8c309ae commit 0e05c17

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

internal/util/portforward.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,16 +192,20 @@ func (pf *PortForward) setupPortForward(podName string) error {
192192
pf.forwarder = fw
193193

194194
// Start forwarding in background
195+
errChan := make(chan error, 1)
195196
go func() {
196197
if err := fw.ForwardPorts(); err != nil {
197198
pf.setStatus(StatusFailed, err)
199+
errChan <- err
198200
}
199201
}()
200202

201-
// Wait for ready or timeout
203+
// Wait for ready, error, or timeout
202204
select {
203205
case <-pf.readyChan:
204206
return nil
207+
case err := <-errChan:
208+
return fmt.Errorf("port-forward failed: %w", err)
205209
case <-time.After(kubeAPITimeout):
206210
return fmt.Errorf("timeout waiting for port-forward to be ready")
207211
}

0 commit comments

Comments
 (0)