Increment download count only after saving

simolus3 · simolus3 · commit d54e33756fd9 · 2025-05-21T17:08:44.000+02:00
diff --git a/core/src/commonMain/kotlin/com/powersync/sync/SyncStream.kt b/core/src/commonMain/kotlin/com/powersync/sync/SyncStream.kt
@@ -436,8 +436,8 @@ internal class SyncStream(
         state: SyncStreamState,
     ): SyncStreamState {
         val batch = SyncDataBatch(listOf(data))
-        status.update { copy(downloading = true, downloadProgress = downloadProgress?.incrementDownloaded(batch)) }
         bucketStorage.saveSyncData(batch)
+        status.update { copy(downloading = true, downloadProgress = downloadProgress?.incrementDownloaded(batch)) }
         return state
     }
 

Original file line number	Diff line number	Diff line change
`@@ -436,8 +436,8 @@ internal class SyncStream(`
`436`	`436`	`state: SyncStreamState,`
`437`	`437`	`): SyncStreamState {`
`438`	`438`	`val batch = SyncDataBatch(listOf(data))`
`439`		`- status.update { copy(downloading = true, downloadProgress = downloadProgress?.incrementDownloaded(batch)) }`
`440`	`439`	`bucketStorage.saveSyncData(batch)`
	`440`	`+ status.update { copy(downloading = true, downloadProgress = downloadProgress?.incrementDownloaded(batch)) }`
`441`	`441`	`return state`
`442`	`442`	`}`
`443`	`443`