Navigator locks are now aquired with a random/unique key. (#546)

Chriztiaan · web-flow · commit fafd562d6d79 · 2025-03-26T16:54:53.000+02:00
diff --git a/.changeset/khaki-pears-add.md b/.changeset/khaki-pears-add.md
@@ -0,0 +1,8 @@
+---
+'@powersync/web': minor
+---
+
+Navigator locks are now aquired with a random/unique key.
+
+This resolves an issue related to sequential `connect()` calls breaking all syncing and never reaching a `connected` state.
+Two typical scenarios that can cause this is switching client parameters and React's `StrictMode` which does multiple calls of hooks like `useEffect`.
diff --git a/packages/web/src/db/adapters/WorkerWrappedAsyncDatabaseConnection.ts b/packages/web/src/db/adapters/WorkerWrappedAsyncDatabaseConnection.ts
@@ -58,7 +58,7 @@ export class WorkerWrappedAsyncDatabaseConnection<Config extends ResolvedWebSQLO
     await new Promise<void>((resolve, reject) =>
       navigator.locks
         .request(
-          `shared-connection-${this.options.identifier}`,
+          `shared-connection-${this.options.identifier}-${Date.now()}-${Math.round(Math.random() * 10000)}`,
           {
             signal: this.lockAbortController.signal
           },

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ export class WorkerWrappedAsyncDatabaseConnection<Config extends ResolvedWebSQLO`
`58`	`58`	`await new Promise<void>((resolve, reject) =>`
`59`	`59`	`navigator.locks`
`60`	`60`	`.request(`
`61`		- `shared-connection-${this.options.identifier}`,
	`61`	+ `shared-connection-${this.options.identifier}-${Date.now()}-${Math.round(Math.random() * 10000)}`,
`62`	`62`	`{`
`63`	`63`	`signal: this.lockAbortController.signal`
`64`	`64`	`},`