Skip to content

Commit 6408783

Browse files
authored
fix: Tanstack react query watch issues (#368)
1 parent 30825f3 commit 6408783

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

.changeset/gorgeous-pens-give.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@powersync/tanstack-react-query': patch
3+
---
4+
5+
Fixed issue with queries not reacting to local data changes or causing an infinite loop on certain sql parameters.

packages/tanstack-react-query/src/hooks/useQuery.ts

+6-3
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,9 @@ function useQueryCore<
8989
}
9090
}
9191

92+
const stringifiedParams = JSON.stringify(queryParameters);
93+
const stringifiedKey = JSON.stringify(options.queryKey);
94+
9295
const fetchTables = async () => {
9396
try {
9497
const tables = await powerSync.resolveTables(sqlStatement, queryParameters);
@@ -104,7 +107,7 @@ function useQueryCore<
104107
(async () => {
105108
await fetchTables();
106109
})();
107-
}, [powerSync, sqlStatement, queryParameters]);
110+
}, [powerSync, sqlStatement, stringifiedParams]);
108111

109112
const queryFn = React.useCallback(async () => {
110113
if (error) {
@@ -116,7 +119,7 @@ function useQueryCore<
116119
} catch (e) {
117120
return Promise.reject(e);
118121
}
119-
}, [powerSync, query, parameters, options.queryKey, error]);
122+
}, [powerSync, query, parameters, stringifiedKey, error]);
120123

121124
React.useEffect(() => {
122125
if (error || !query) return () => {};
@@ -139,7 +142,7 @@ function useQueryCore<
139142
}
140143
);
141144
return () => abort.abort();
142-
}, [powerSync, options.queryKey, queryClient, tables, error]);
145+
}, [powerSync, queryClient, stringifiedKey, tables, error]);
143146

144147
return useQueryFn(
145148
{

0 commit comments

Comments
 (0)