Skip to content

Commit 3e92a9c

Browse files
DominicGBauerDominicGBauer
andauthored
fix: kysely closing db on execute (#155)
Co-authored-by: DominicGBauer <[email protected]>
1 parent 49299b6 commit 3e92a9c

File tree

4 files changed

+11
-7
lines changed

4 files changed

+11
-7
lines changed

.changeset/metal-cheetahs-try.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@powersync/kysely-driver": minor
3+
---
4+
5+
Made `destroy` and `releaseConnection` no-op functions. If you relied on `destroy` you will need to use `disconnectAndClear` on the PowerSync DB directly.

packages/kysely-driver/src/sqlite/sqlite-connection.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,7 @@ export class PowerSyncConnection implements DatabaseConnection {
105105
this.releaseTransaction();
106106
}
107107

108-
async releaseConnection(): Promise<void> {
109-
this.#db.close();
110-
}
108+
async releaseConnection(): Promise<void> {}
111109

112110
private releaseTransaction() {
113111
if (!this.#completeTransaction) {

packages/kysely-driver/src/sqlite/sqlite-driver.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@ export class PowerSyncDriver implements Driver {
3535
await connection.releaseConnection();
3636
}
3737

38-
async destroy(): Promise<void> {
39-
this.#db.disconnectAndClear();
40-
}
38+
/**
39+
This will do nothing. Instead use PowerSync `disconnectAndClear` function.
40+
*/
41+
async destroy(): Promise<void> {}
4142
}

packages/kysely-driver/tests/sqlite/db.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ describe('CRUD operations', () => {
1515
});
1616

1717
afterEach(async () => {
18-
await db.destroy();
18+
await powerSyncDb.disconnectAndClear();
1919
});
2020

2121
it('should insert a user and select that user', async () => {

0 commit comments

Comments
 (0)