Do a safer/better job of parsing dependency versions (#66)

* Close #65: do a safer/better job of parsing dependency versions

* Attempt to fix python 3.7 install error

* Drop python 3.7, start running tests on python 3.11

* Start a CHANGELOG

Author: cpsievert

.github/workflows/pytest.yaml

@@ -13,7 +13,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: [3.7, 3.8, 3.9, "3.10"]
+        python-version: [3.8, 3.9, "3.10", "3.11"]
       fail-fast: false
 
     steps:

CHANGELOG.md

@@ -0,0 +1,16 @@
+# Change Log for Shiny (for Python)
+
+All notable changes to Shiny for Python will be documented in this file.
+
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
+and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+
+## [UNRELEASED]
+
+### Bug fixes
+
+* Closed #65: get shinywidgets working with ipywidgets 8.0.3.
+
+## [0.1.2] - 2022-07-27
+
+Initial release of shinywidgets

setup.cfg

@@ -15,7 +15,6 @@ classifiers =
     Intended Audience :: Developers
     License :: OSI Approved :: MIT License
     Natural Language :: English
-    Programming Language :: Python :: 3.7
     Programming Language :: Python :: 3.8
     Programming Language :: Python :: 3.9
     Programming Language :: Python :: 3.10
@@ -25,7 +24,7 @@ project_urls =
     Source Code = https://github.com/rstudio/py-shinywidgets/
 
 [options]
-python_requires = >=3.7
+python_requires = >=3.8
 packages = find:
 test_suite = tests
 include_package_data = True

shinywidgets/_dependencies.py

@@ -42,7 +42,7 @@ def libembed_dependency() -> List[HTMLDependency]:
         # stuff we need to render widgets outside of the notebook.
         HTMLDependency(
             name="ipywidget-libembed-amd",
-            version=as_version(__html_manager_version__),
+            version=parse_version_safely(__html_manager_version__),
             source={"package": "shinywidgets", "subdir": "static"},
             script={"src": "libembed-amd.js"},
         ),
@@ -93,7 +93,7 @@ def require_dependency(w: Widget, session: Session) -> Optional[HTMLDependency]:
             )
             return None
 
-    version = as_version(getattr(w, "_model_module_version", "1.0"))
+    version = parse_version_safely(getattr(w, "_model_module_version", "1.0"))
     source = HTMLDependencySource(subdir=module_dir)
 
     dep = HTMLDependency(module_name, version, source=source)
@@ -156,5 +156,21 @@ def widget_pkg(w: object) -> str:
     return w.__module__.split(".")[0]
 
 
-def as_version(v: str) -> str:
-    return re.sub("\\D*", "", str(packaging.version.parse(v)))
+def parse_version(v: str) -> str:
+    # version could be in node-semver format
+    # which is not compatible with packaging.version.parse
+    # so we strip out the leading non-numeric characters
+    # e.g., ^1.2.3 -> 1.2.3
+    ver = re.sub("^\\D+", "", v)
+    return str(packaging.version.parse(ver))
+
+
+# parsing can fail if the version is something like "*",
+# but it doesn't seem vital that we obtain the _actual_ version
+# since this only gets the version of the HTMLManager and module
+# dependencies, which should be unique within a given session
+def parse_version_safely(v: str) -> str:
+    try:
+        return parse_version(v)
+    except Exception:
+        return "0.0"