Skip to content

Allow for OpenRPC message components to be shared between comms #7299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wesm opened this issue Apr 17, 2025 · 0 comments · May be fixed by #7450
Open

Allow for OpenRPC message components to be shared between comms #7299

wesm opened this issue Apr 17, 2025 · 0 comments · May be fixed by #7450
Labels
area: core Issues related to Core category. area: data explorer Issues related to Data Explorer category. enhancement New feature or request
Milestone

Comments

@wesm
Copy link
Contributor

wesm commented Apr 17, 2025

In thinking about #7114 -- we need to allow for some amount of stateless data querying capability in the variables service. Currently all of the logic that exists for this in the runtime comms layer exists in the data explorer comm, but we could reuse many of these data structures to reduce duplication and improve maintainability.

I was thinking that we could define a common.json file in positron/comms with a set of OpenRPC schemas that can be referenced from any of the other comm-specific service definitions -- something like "$ref": "common.json#/data_explorer/..." compared with the current #/components/schemas/... -- see https://github.com/Mermade/open-rpc-spec/blob/master/README.md#reference-object). This would sharing schemas more easily.

@wesm wesm added area: core Issues related to Core category. area: data explorer Issues related to Data Explorer category. enhancement New feature or request labels Apr 17, 2025
@juliasilge juliasilge added this to the Future milestone Apr 23, 2025
@lionel- lionel- linked a pull request Apr 30, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: core Issues related to Core category. area: data explorer Issues related to Data Explorer category. enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants