Notify backends of sizing policy changes

Author: lionel-

src/vs/workbench/contrib/positronPlots/browser/components/plotsContainer.tsx

@@ -25,6 +25,7 @@ import { DarkFilter, IPositronPlotClient, IPositronPlotsService, PlotRenderForma
 import { StaticPlotClient } from '../../../../services/positronPlots/common/staticPlotClient.js';
 import { PlotSizingPolicyIntrinsic } from '../../../../services/positronPlots/common/sizingPolicyIntrinsic.js';
 import { PlotSizingPolicyAuto } from '../../../../services/positronPlots/common/sizingPolicyAuto.js';
+import { DisposableStore } from '../../../../../base/common/lifecycle.js';
 
 /**
  * PlotContainerProps interface.
@@ -94,27 +95,37 @@ export const PlotsContainer = (props: PlotContainerProps) => {
 			return;
 		}
 
-		let policy = props.positronPlotsService.selectedSizingPolicy;
+		const notify = () => {
+			let policy = props.positronPlotsService.selectedSizingPolicy;
 
-		if (policy instanceof PlotSizingPolicyIntrinsic) {
-			policy = new PlotSizingPolicyAuto;
-		}
+			if (policy instanceof PlotSizingPolicyIntrinsic) {
+				policy = new PlotSizingPolicyAuto;
+			}
 
-		const viewPortSize = {
-			height: plotHeight,
-			width: plotWidth,
-		}
-		let size = policy.getPlotSize(viewPortSize);
-		size = size ? size : viewPortSize;
+			const viewPortSize = {
+				height: plotHeight,
+				width: plotWidth,
+			}
+			let size = policy.getPlotSize(viewPortSize);
+			size = size ? size : viewPortSize;
 
-		// Propagate current render settings. Use a debouncer to avoid excessive
-		// messaging to language kernels.
-		const debounceTimer = setTimeout(() => {
 			props.positronPlotsService.setPlotsRenderSettings({
 				size,
 				pixel_ratio: DOM.getActiveWindow().devicePixelRatio,
 				format: PlotRenderFormat.Png, // Currently hard-coded
 			});
+		};
+
+		// Renotify if the sizing policy changes
+		const disposables = new DisposableStore();
+		disposables.add(props.positronPlotsService.onDidChangeSizingPolicy((_policy) => {
+			notify();
+		}));
+
+		// Propagate current render settings. Use a debouncer to avoid excessive
+		// messaging to language kernels.
+		const debounceTimer = setTimeout(() => {
+			notify()
 		}, 500);
 
 		return () => clearTimeout(debounceTimer);

src/vs/workbench/contrib/positronPlots/browser/positronPlotsService.ts

@@ -1350,6 +1350,10 @@ export class PositronPlotsService extends Disposable implements IPositronPlotsSe
 	 * @param settings The new settings.
 	 */
 	setPlotsRenderSettings(settings: PlotRenderSettings): void {
+		// Sanitize values in case sizing policies create floating points
+		settings.size.height = Math.floor(settings.size.height);
+		settings.size.width = Math.floor(settings.size.width);
+
 		this._plotsRenderSettings.set(settings, undefined);
 	}