hide panel when there is no participant

Author: jmcphers

src/vs/workbench/contrib/chat/browser/chatParticipant.contribution.ts

@@ -81,12 +81,21 @@ const chatViewDescriptor: IViewDescriptor[] = [{
 		order: 1
 	},
 	ctorDescriptor: new SyncDescriptor(ChatViewPane, [{ location: ChatAgentLocation.Panel }]),
+	// --- Start Positron ---
+	// Do not show the Chat pane at all if there are no participants registered;
+	// this is the case when Assistant is disabled entirely.
+	//
+	// Old version:
+	/*
 	when: ContextKeyExpr.or(
 		ChatContextKeys.Setup.hidden.negate(),
 		ChatContextKeys.Setup.installed,
 		ChatContextKeys.panelParticipantRegistered,
 		ChatContextKeys.extensionInvalid
 	)
+	*/
+	when: ChatContextKeys.panelParticipantRegistered,
+	// --- End Positron ---
 }];
 Registry.as<IViewsRegistry>(ViewExtensions.ViewsRegistry).registerViews(chatViewDescriptor, chatViewContainer);
 

src/vs/workbench/contrib/chat/common/chatAgents.ts

@@ -29,6 +29,10 @@ import { IRawChatCommandContribution } from './chatParticipantContribTypes.js';
 import { IChatFollowup, IChatLocationData, IChatProgress, IChatResponseErrorDetails, IChatTaskDto } from './chatService.js';
 import { ChatAgentLocation, ChatMode } from './constants.js';
 
+// --- Start Positron ---
+import { IConfigurationService } from '../../../../platform/configuration/common/configuration.js';
+// --- End Positron ---
+
 //#region agent service, commands etc
 
 export interface IChatAgentHistoryEntry {
@@ -243,6 +247,9 @@ export class ChatAgentService extends Disposable implements IChatAgentService {
 
 	constructor(
 		@IContextKeyService private readonly contextKeyService: IContextKeyService,
+		// --- Start Positron ---
+		@IConfigurationService private readonly configurationService: IConfigurationService,
+		// --- End Positron ---
 	) {
 		super();
 		this._hasDefaultAgent = ChatContextKeys.enabled.bindTo(this.contextKeyService);
@@ -316,7 +323,13 @@ export class ChatAgentService extends Disposable implements IChatAgentService {
 			}
 		}
 		this._editingAgentRegistered.set(editingAgentRegistered);
-		this._defaultAgentRegistered.set(defaultAgentRegistered);
+		// --- Start Positron ---
+		// Do not register default agents when Assistant is disabled.
+		// this._defaultAgentRegistered.set(defaultAgentRegistered);
+		if (this.configurationService.getValue('positron.assistant.enable')) {
+			this._defaultAgentRegistered.set(defaultAgentRegistered);
+		}
+		// --- End Positron ---
 		if (toolsAgentRegistered !== this._hasToolsAgentContextKey.get()) {
 			this._hasToolsAgentContextKey.set(toolsAgentRegistered);
 			this._onDidChangeAgents.fire(this.getDefaultAgent(ChatAgentLocation.EditingSession));

src/vs/workbench/contrib/chat/test/common/chatAgents.test.ts

@@ -10,6 +10,10 @@ import { ExtensionIdentifier } from '../../../../../platform/extensions/common/e
 import { MockContextKeyService } from '../../../../../platform/keybinding/test/common/mockKeybindingService.js';
 import { ChatAgentService, IChatAgentData, IChatAgentImplementation } from '../../common/chatAgents.js';
 
+// --- Start Positron ---
+import { TestConfigurationService } from '../../../../../platform/configuration/test/common/testConfigurationService.js';
+// --- End Positron ---
+
 const testAgentId = 'testAgent';
 const testAgentData: IChatAgentData = {
 	id: testAgentId,
@@ -39,9 +43,16 @@ suite('ChatAgents', function () {
 
 	let chatAgentService: ChatAgentService;
 	let contextKeyService: TestingContextKeyService;
+	// --- Start Positron ---
+	let configurationService: TestConfigurationService;
+	// --- End Positron ---
 	setup(() => {
 		contextKeyService = new TestingContextKeyService();
-		chatAgentService = store.add(new ChatAgentService(contextKeyService));
+		// --- Start Positron ---
+		// Add configuration service to chat
+		configurationService = new TestConfigurationService();
+		chatAgentService = store.add(new ChatAgentService(contextKeyService, configurationService));
+		// --- End Positron ---
 	});
 
 	test('registerAgent', async () => {