From a1762b186383fd3b3496b19b1fc18dd5f14ad875 Mon Sep 17 00:00:00 2001 From: Matt Conflitti Date: Mon, 5 May 2025 11:12:10 -0400 Subject: [PATCH 1/3] removed an unnecessary check that causes breaking change with older versions of connect --- R/get.R | 6 ------ 1 file changed, 6 deletions(-) diff --git a/R/get.R b/R/get.R index 5d5a87a2..6275b115 100644 --- a/R/get.R +++ b/R/get.R @@ -674,9 +674,6 @@ get_oauth_credentials <- function( requested_token_type = NULL ) { validate_R6_class(connect, "Connect") - if (is.null(requested_token_type)) { - requested_token_type <- "urn:ietf:params:oauth:token-type:access_token" - } url <- v1_url("oauth", "integrations", "credentials") body <- list( grant_type = "urn:ietf:params:oauth:grant-type:token-exchange", @@ -743,9 +740,6 @@ get_oauth_content_credentials <- function( ) } } - if (is.null(requested_token_type)) { - requested_token_type <- "urn:ietf:params:oauth:token-type:access_token" - } url <- v1_url("oauth", "integrations", "credentials") body <- list( grant_type = "urn:ietf:params:oauth:grant-type:token-exchange", From ada8b1790204e6ff53ad18a1c1e67496130fd1cd Mon Sep 17 00:00:00 2001 From: Matt Conflitti Date: Mon, 5 May 2025 11:25:36 -0400 Subject: [PATCH 2/3] fixed test hashes --- ...{credentials-b3e87e-POST.json => credentials-f08930-POST.json} | 0 ...{credentials-8dea8e-POST.json => credentials-fe6213-POST.json} | 0 2 files changed, 0 insertions(+), 0 deletions(-) rename tests/testthat/2024.08.0/__api__/v1/oauth/integrations/{credentials-b3e87e-POST.json => credentials-f08930-POST.json} (100%) rename tests/testthat/2024.08.0/__api__/v1/oauth/integrations/{credentials-8dea8e-POST.json => credentials-fe6213-POST.json} (100%) diff --git a/tests/testthat/2024.08.0/__api__/v1/oauth/integrations/credentials-b3e87e-POST.json b/tests/testthat/2024.08.0/__api__/v1/oauth/integrations/credentials-f08930-POST.json similarity index 100% rename from tests/testthat/2024.08.0/__api__/v1/oauth/integrations/credentials-b3e87e-POST.json rename to tests/testthat/2024.08.0/__api__/v1/oauth/integrations/credentials-f08930-POST.json diff --git a/tests/testthat/2024.08.0/__api__/v1/oauth/integrations/credentials-8dea8e-POST.json b/tests/testthat/2024.08.0/__api__/v1/oauth/integrations/credentials-fe6213-POST.json similarity index 100% rename from tests/testthat/2024.08.0/__api__/v1/oauth/integrations/credentials-8dea8e-POST.json rename to tests/testthat/2024.08.0/__api__/v1/oauth/integrations/credentials-fe6213-POST.json From 64bf067005748ee5e04cf19b7da398b6bdb26a94 Mon Sep 17 00:00:00 2001 From: Matt Conflitti Date: Tue, 6 May 2025 16:37:44 -0400 Subject: [PATCH 3/3] updated news.md --- NEWS.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/NEWS.md b/NEWS.md index 923bfff0..5942eed2 100644 --- a/NEWS.md +++ b/NEWS.md @@ -9,6 +9,9 @@ rather than in UTC. (#400) - `get_content()` now includes vanity URLs in the returned data frame on Connect v2024.06.0 and later. (#398) +- Removed unnecessary null check with default from `get_oauth_credentials()` and + `get_oauth_content_credentials()` functions for `requested_token_type` parameter + that was causing issues with Connect < 2025.03.0. (#407) # connectapi 0.7.0