Merge pull request #190 from rstudio/aron-remove-experimental-bundle-use

remove experimental bundle use

Author: colearendt

NEWS.md

@@ -1,5 +1,9 @@
 # connectapi (development version)
 
+- BREAKING: The functions `Connect$download_bundle()` and
+  `Connect$bundle_delete()` have been removed. Use `Content$bundle_download()`
+  and `Content$bundle_delete()` instead.
+
 # connectapi 0.1.3.1
 
 - Fix generated documentation HTML for CRAN submission

R/connect.R

@@ -393,19 +393,6 @@ Connect <- R6::R6Class(
       )
     },
 
-    download_bundle = function(bundle_id, to_path = tempfile(), overwrite=FALSE) {
-      lifecycle::deprecate_soft("0.1.1", "Connect$downlod_bundle()", "Content$bundle_download()")
-      path <- glue::glue("v1/experimental/bundles/{bundle_id}/download")
-      self$GET(path, httr::write_disk(to_path, overwrite = overwrite), "raw")
-      to_path
-    },
-
-    bundle_delete = function(bundle_id) {
-      lifecycle::deprecate_soft("0.1.1", "Connect$bundle_delete()", "Content$bundle_delete()")
-      path <- glue::glue("v1/experimental/bundles/{bundle_id}")
-      self$DELETE(path)
-    },
-
     content_upload = function(bundle_path, guid) {
       # todo : add X-Content-Checksum
       path <- glue::glue("v1/content/{guid}/bundles")

R/deploy.R

@@ -166,7 +166,7 @@ Vanity <- R6::R6Class(
 #' @export
 #' @examplesIf identical(Sys.getenv("IN_PKGDOWN"), "true")
 #'
-#' bundle_dir(system.file("tests/testthat/examples/shiny/", package = "connectapi))
+#' bundle_dir(system.file("tests/testthat/examples/shiny/", package = "connectapi"))
 bundle_dir <- function(path = ".", filename = fs::file_temp(pattern = "bundle", ext = ".tar.gz")) {
 
   # TODO: check for manifest.json
@@ -215,7 +215,7 @@ check_bundle_contents <- function(dir) {
 #'
 #' @examplesIf identical(Sys.getenv("IN_PKGDOWN"), "true")
 #'
-#' bundle_static(system.file("logo.png", package = "connectapi))
+#' bundle_static(system.file("logo.png", package = "connectapi"))
 #'
 #' @export
 bundle_static <- function(path, filename = fs::file_temp(pattern = "bundle", ext = ".tar.gz")) {
@@ -239,7 +239,7 @@ bundle_static <- function(path, filename = fs::file_temp(pattern = "bundle", ext
 #' @export
 #' @examplesIf identical(Sys.getenv("IN_PKGDOWN"), "true")
 #'
-#' bundle_path(system.file("tests/testthat/examples/static.tar.gz", package = "connectapi))
+#' bundle_path(system.file("tests/testthat/examples/static.tar.gz", package = "connectapi"))
 bundle_path <- function(path) {
   # TODO: need a check on filetype
   # TODO: a way to check that the .tar.gz has a manifest.json?
@@ -327,7 +327,7 @@ download_bundle <- function(content, filename = fs::file_temp(pattern = "bundle"
 #' @examplesIf identical(Sys.getenv("IN_PKGDOWN"), "true")
 #'
 #' client <- connect(prefix = "TEST_1")
-#' bnd <- bundle_path(system.file("tests/testthat/examples/static.tar.gz", package = "connectapi))
+#' bnd <- bundle_path(system.file("tests/testthat/examples/static.tar.gz", package = "connectapi"))
 #' deploy(client, bnd)
 #'
 deploy <- function(connect, bundle, name = create_random_name(), title = name, guid = NULL, ..., .pre_deploy = {}) {