Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Anchor Component #2

Open
furti opened this issue Nov 1, 2017 · 1 comment
Open

Duplicate Anchor Component #2

furti opened this issue Nov 1, 2017 · 1 comment
Labels

Comments

@furti
Copy link
Member

furti commented Nov 1, 2017

Why is there a at.porscheinformatik.seleniumcomponents.component.LinkComponent and a at.porscheinformatik.seleniumcomponents.component.AComponent for the same thing, a HTML anchor element?

AComponent is not the best name for a component btw. because it looks so generic.
Given that SeleniumContainer uses a generic type of AnyChildComponent the name AComponent is really confusing.

@thred thred added the question label Nov 1, 2017
@thred
Copy link
Member

thred commented Nov 1, 2017

Yep. Had my problems with the name, too. On one hand we could name components like the HTML tags. The name "AComponent" is correct in this case. On the other hand, we could name the components more generic, like "LinkComponent", "HtmlComponent", "BlockComponent". First, I thought it's better to name the elements like the HTML tags for a couple of reasons, e.g. that you can skip the selector or build special components for Angular. But the more I use these component, it seems better to build and use generic components. Currently I would remove the explicitly named components and just use generic ones. Ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants