Skip to content

Commit 6e06b38

Browse files
committed
More test improvements
1 parent b50ac1f commit 6e06b38

File tree

4 files changed

+20
-10
lines changed

4 files changed

+20
-10
lines changed

cbor/src/test/java/com/fasterxml/jackson/dataformat/cbor/CBORTestBase.java

+5
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,11 @@ protected void assertToken(JsonToken expToken, JsonParser p)
113113
assertToken(expToken, p.getCurrentToken());
114114
}
115115

116+
protected void assertNameToken(JsonToken actToken)
117+
{
118+
assertToken(JsonToken.FIELD_NAME, actToken);
119+
}
120+
116121
protected void assertType(Object ob, Class<?> expType)
117122
{
118123
if (ob == null) {

cbor/src/test/java/com/fasterxml/jackson/dataformat/cbor/failing/SymbolTable312Test.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -58,27 +58,27 @@ public void _testNullHandling(int minNulls) throws Exception
5858
try (JsonParser p = MAPPER.createParser(DOC)) {
5959
assertToken(JsonToken.START_OBJECT, p.nextToken());
6060

61-
assertToken(JsonToken.FIELD_NAME, p.nextToken());
61+
assertNameToken(p.nextToken());
6262
_assertNullStrings(FIELD1, p.currentName());
6363
assertToken(JsonToken.VALUE_STRING, p.nextToken());
6464
assertEquals("a", p.getText());
6565

66-
assertToken(JsonToken.FIELD_NAME, p.nextToken());
66+
assertNameToken(p.nextToken());
6767
_assertNullStrings(FIELD2, p.currentName());
6868
assertToken(JsonToken.VALUE_STRING, p.nextToken());
6969
assertEquals("b", p.getText());
7070

71-
assertToken(JsonToken.FIELD_NAME, p.nextToken());
71+
assertNameToken(p.nextToken());
7272
_assertNullStrings(FIELD3, p.currentName());
7373
assertToken(JsonToken.VALUE_STRING, p.nextToken());
7474
assertEquals("c", p.getText());
7575

76-
assertToken(JsonToken.FIELD_NAME, p.nextToken());
76+
assertNameToken(p.nextToken());
7777
_assertNullStrings(FIELD4, p.currentName());
7878
assertToken(JsonToken.VALUE_STRING, p.nextToken());
7979
assertEquals("d", p.getText());
8080

81-
assertToken(JsonToken.FIELD_NAME, p.nextToken());
81+
assertNameToken(p.nextToken());
8282
_assertNullStrings(FIELD5, p.currentName());
8383
assertToken(JsonToken.VALUE_STRING, p.nextToken());
8484
assertEquals("e", p.getText());

smile/src/test/java/com/fasterxml/jackson/dataformat/smile/BaseTestForSmile.java

+5
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,11 @@ protected void assertToken(JsonToken expToken, JsonParser p)
167167
assertToken(expToken, p.getCurrentToken());
168168
}
169169

170+
protected void assertNameToken(JsonToken actToken)
171+
{
172+
assertToken(JsonToken.FIELD_NAME, actToken);
173+
}
174+
170175
protected void assertType(Object ob, Class<?> expType)
171176
{
172177
if (ob == null) {

smile/src/test/java/com/fasterxml/jackson/dataformat/smile/failing/SymbolTable312Test.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -57,27 +57,27 @@ public void _testNullHandling(int minNulls) throws Exception
5757
try (JsonParser p = MAPPER.createParser(DOC)) {
5858
assertToken(JsonToken.START_OBJECT, p.nextToken());
5959

60-
assertToken(JsonToken.FIELD_NAME, p.nextToken());
60+
assertNameToken(p.nextToken());
6161
_assertNullStrings(FIELD1, p.currentName());
6262
assertToken(JsonToken.VALUE_STRING, p.nextToken());
6363
assertEquals("a", p.getText());
6464

65-
assertToken(JsonToken.FIELD_NAME, p.nextToken());
65+
assertNameToken(p.nextToken());
6666
_assertNullStrings(FIELD2, p.currentName());
6767
assertToken(JsonToken.VALUE_STRING, p.nextToken());
6868
assertEquals("b", p.getText());
6969

70-
assertToken(JsonToken.FIELD_NAME, p.nextToken());
70+
assertNameToken(p.nextToken());
7171
_assertNullStrings(FIELD3, p.currentName());
7272
assertToken(JsonToken.VALUE_STRING, p.nextToken());
7373
assertEquals("c", p.getText());
7474

75-
assertToken(JsonToken.FIELD_NAME, p.nextToken());
75+
assertNameToken(p.nextToken());
7676
_assertNullStrings(FIELD4, p.currentName());
7777
assertToken(JsonToken.VALUE_STRING, p.nextToken());
7878
assertEquals("d", p.getText());
7979

80-
assertToken(JsonToken.FIELD_NAME, p.nextToken());
80+
assertNameToken(p.nextToken());
8181
_assertNullStrings(FIELD5, p.currentName());
8282
assertToken(JsonToken.VALUE_STRING, p.nextToken());
8383
assertEquals("e", p.getText());

0 commit comments

Comments
 (0)