chore: fix clippy warnings

Author: Aloso

pomsky-bin/src/format.rs

@@ -47,15 +47,15 @@ impl Logger {
         }
     }
 
-    pub(crate) fn basic(&self) -> Formatted<FormatBasic> {
+    pub(crate) fn basic(&self) -> Formatted<'_, FormatBasic> {
         Formatted { format: FormatBasic, logger: self }
     }
 
     pub(crate) fn diagnostic<'a>(
         &self,
         severity: Severity,
         kind: &'a str,
-    ) -> Formatted<FormatDetailed<'a, 4>> {
+    ) -> Formatted<'_, FormatDetailed<'a, 4>> {
         let label = match severity {
             Severity::Error => Segment { style: Some(Style::R), text: "error", ticks: false },
             Severity::Warning => Segment { style: Some(Style::Y), text: "warning", ticks: false },
@@ -69,7 +69,7 @@ impl Logger {
         severity: Severity,
         code: &'a str,
         kind: &'a str,
-    ) -> Formatted<FormatDetailed<'a, 5>> {
+    ) -> Formatted<'_, FormatDetailed<'a, 5>> {
         let label = match severity {
             Severity::Error => Segment { style: Some(Style::R), text: "error ", ticks: false },
             Severity::Warning => Segment { style: Some(Style::Y), text: "warning ", ticks: false },
@@ -84,15 +84,15 @@ impl Logger {
         Formatted { format: FormatDetailed { start }, logger: self }
     }
 
-    pub(crate) fn error(&self) -> Formatted<FormatError> {
+    pub(crate) fn error(&self) -> Formatted<'_, FormatError> {
         Formatted { format: FormatError, logger: self }
     }
 
-    pub(crate) fn warn(&self) -> Formatted<FormatWarning> {
+    pub(crate) fn warn(&self) -> Formatted<'_, FormatWarning> {
         Formatted { format: FormatWarning, logger: self }
     }
 
-    pub(crate) fn note(&self) -> Formatted<FormatNote> {
+    pub(crate) fn note(&self) -> Formatted<'_, FormatNote> {
         Formatted { format: FormatNote, logger: self }
     }
 }

pomsky-syntax/src/parse/parser_impl.rs

@@ -568,7 +568,7 @@ impl<'i> Parser<'i> {
                     return Err(PEK::UnallowedNot.at(nots_span));
                 }
                 group
-            } else if let Some(group) = self.parse_char_group_ident(nots % 2 != 0)? {
+            } else if let Some(group) = self.parse_char_group_ident(!nots.is_multiple_of(2))? {
                 if nots > 1 {
                     return Err(PEK::UnallowedMultiNot(nots).at(nots_span));
                 }

pomsky-syntax/src/pretty_print.rs

@@ -15,7 +15,7 @@ impl PrettyPrinter {
     }
 
     fn add_spaces(&mut self, n: usize) {
-        self.buf.extend(std::iter::repeat(' ').take(n));
+        self.buf.extend(std::iter::repeat_n(' ', n));
     }
 
     pub(crate) fn write(&mut self, s: &str) {
@@ -63,14 +63,14 @@ impl PrettyPrinter {
         self.buf.push_str(paren);
         self.indent += 2;
         self.buf.push('\n');
-        self.buf.extend(std::iter::repeat(' ').take(self.indent));
+        self.buf.extend(std::iter::repeat_n(' ', self.indent));
     }
 
     pub(crate) fn end_indentation(&mut self, paren: &str) {
         debug_assert!(!paren.contains('\n'));
         self.indent = self.indent.saturating_sub(2);
         self.buf.push('\n');
-        self.buf.extend(std::iter::repeat(' ').take(self.indent));
+        self.buf.extend(std::iter::repeat_n(' ', self.indent));
         self.buf.push_str(paren);
     }