-
Notifications
You must be signed in to change notification settings - Fork 678
Description
General question up front: Do you prefer 'issue' or 'PR' ?
Since there are pending issues #48 and pending PR #37 playaswd:fix-typos I did not use PR.
Problem:
On case sensitive operating systems (e.g. linux), the lines in src/components/LinearSoftmax.svelte
24: import SoftmaxPopover from './popovers/SoftmaxPopover.svelte';
25: import LogitWeightPopover from './popovers/LogitWeightPopover.svelte';
conflict with the folder name
transformer-explainer/src/components/Popovers
leading to an error
Failed to load url ./popovers/SoftmaxPopover.svelte (resolved id: ./popovers/SoftmaxPopover.svelte) in /<example-path>/transformer-explainer/src/components/LinearSoftmax.svelte. Does the file exist?
Proposed solution:
Rename folder "Popovers" to "popovers".
[Tested on LinuxMint 22.2 (zara) with npm 10.8.2 and node 20.19.5]
This seems easier and more consistent with general folder naming convention in the project, than changing multiple code targets.
General remark: Thanks & kudos! This is, by far, the best didactic visualization of transformer architecture that I have come across...